Activity leahi-application/

Tree
Accordion

Stats

Commits this week: 34

Total Committers:	7
Last Commit:	31 Dec 69
Commits this week:	34

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

5 hrs ago

Nicholas Ramirez

updated

updated

5 hrs ago

Nicholas Ramirez

updated

updated

5 hrs ago

Nicholas Ramirez

updated

updated

5 hrs ago

Nicholas Ramirez

updated

updated

5 hrs ago

Nicholas Ramirez

More
f41f561
changed 2 files
feature/LDT-5600-DD-calibration LEAHI-APPLICATION-LDT-5600-1

LDT-5602 Service - SW - Calibration Records DD - I&C - 02: SDD - Design Diagram - plantuml & Review

addre4ss cr comments

- -20
- +44
/SDDs/DD_Calibration.puml
- History
- Source
- Diff
/SDDs/DD_Calibration.puml
- binary
/SDDs/dd_calibration.png
- History
- Source
- Diff
/SDDs/dd_calibration.png

6 hrs ago

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5600-1
commented on review

send rejection reasons

send rejection reasons

6 hrs ago

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5600-1
commented on review

add separate sections for each set of messages

add separate sections for each set of messages

6 hrs ago

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5600-1
commented on review

add alt rejection for this

add alt rejection for this

6 hrs ago

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5600-1
commented on review

move these under the alt password check

move these under the alt password check

6 hrs ago

Nicholas Ramirez

bn approves

bn approves

6 hrs ago

Nicholas Ramirez

BN approvo

BN approvo

7 hrs ago

Nicholas Ramirez

More
31ff749
added 2 files
feature/LDT-5600-DD-calibration LEAHI-APPLICATION-LDT-5600-1

LDT-5602 Service - SW - Calibration Records DD - I&C - 02: SDD - Design Diagram - plantuml & Review

add sdd

- -0
- +166
/SDDs/DD_Calibration.puml
- History
- Source
/SDDs/DD_Calibration.puml
- binary
/SDDs/dd_calibration.png
- History
- Source
/SDDs/dd_calibration.png

9 hrs ago

Dara Navaei

More
LEAHI-APPLICATION-LDT-5600-1
started review

LEAHI-APPLICATION-LDT-5600_Service - SW - Calibration Records DD - I&C

LEAHI-APPLICATION-LDT-5600_Service - SW - Calibration Records DD - I&C

11 hrs ago

Dara Navaei

More
LEAHI-APPLICATION-LDT-5586-1
started review

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

12 hrs ago

Dara Navaei

Wednesday 19 Aug

9:24 pm

Dara Navaei , Tiffany Mejia , Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-5618-1
finished reviewing

8:09 pm

Behrouz NematiPour

More
b3608f3
changed 0 files
develop, feature/LDT-5104-qt6-port and 4 more

Merge branch 'LDT-5618-sw-misc-enhc-sw-board-freeze' into staging

8:07 pm

Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

8:06 pm

Behrouz NematiPour

More
1244c4e
changed 5 files
LDT-5618-sw-misc-enhc-sw-board-freeze, develop and 5 more LEAHI-APPLICATION-LDT-5618-1

Updated the Alarm Mapping with the staging.

- -16
- +16
/etc/reports/alarms/AlarmMapping.csv
- History
- Source
- Diff
/etc/reports/alarms/AlarmMapping.csv
- -16
- +16
/etc/reports/alarms/AlarmMapping.py
- History
- Source
- Diff
/etc/reports/alarms/AlarmMapping.py
- -1
- +1
/etc/reports/cppcheck/cppcheck.err
- History
- Source
- Diff
/etc/reports/cppcheck/cppcheck.err
- -1
- +1
/etc/reports/cppcheck/cppcheck.log
- History
- Source
- Diff
/etc/reports/cppcheck/cppcheck.log
- -16
- +16
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

4:22 pm

Behrouz NematiPour

More
d6a3db9
changed 0 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, develop and 5 more

Merge branch 'LDT-5618-sw-misc-enhc-sw-board-freeze' into staging

4:21 pm

Behrouz NematiPour

4:07 pm

Behrouz NematiPour

More
582028a
changed 5 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 6 more LEAHI-APPLICATION-LDT-5618-1

Adding Alarm Mapping, since the automation is now disabled for migrations.

- -1
- +111
/etc/reports/alarms/AlarmMapping.csv
- History
- Source
- Diff
/etc/reports/alarms/AlarmMapping.csv
- -5
- +128
/etc/reports/alarms/AlarmMapping.py
- History
- Source
- Diff
/etc/reports/alarms/AlarmMapping.py
- -250
- +457
/etc/reports/cppcheck/cppcheck.err
- History
- Source
- Diff
/etc/reports/cppcheck/cppcheck.err
- -652
- +1275
/etc/reports/cppcheck/cppcheck.log
- History
- Source
- Diff
/etc/reports/cppcheck/cppcheck.log
- -24
- +24
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

3:31 pm

Behrouz NematiPour

More
9f5f28d
changed 3 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 6 more LEAHI-APPLICATION-LDT-5618-1 LEAHI-APPLICATION-LDT-5104-14

Remove AlarmDialog Animation & Diagnostics open

- -1
- +1
/sources/gui/qml/components/HeaderBar.qml
- History
- Source
- Diff
/sources/gui/qml/components/HeaderBar.qml
- -2
- +2
/sources/gui/qml/components/ModalDialog.qml
- History
- Source
- Diff
/sources/gui/.../components/ModalDialog.qml
- -1
- +1
/sources/gui/qml/dialogs/AlarmDialog.qml
- History
- Source
- Diff
/sources/gui/qml/dialogs/AlarmDialog.qml

3:05 pm

Behrouz NematiPour

More
60f7e69
changed 17 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 6 more LEAHI-APPLICATION-LDT-5618-1 LEAHI-APPLICATION-LDT-5104-14

Removing the layers and dropshadow and the diagnostics screen

- -13
- +13
/sources/gui/qml/components/ModalDialog.qml
- History
- Source
- Diff
/sources/gui/.../components/ModalDialog.qml
- -1
- +1
/sources/gui/qml/components/UltrafiltrationButton.qml
- History
- Source
- Diff
/sources/gui/.../UltrafiltrationButton.qml
- -2
- +2
/sources/gui/qml/compounds/NumPad.qml
- History
- Source
- Diff
/sources/gui/qml/compounds/NumPad.qml
- -11
- +11
/sources/gui/qml/dialogs/AlarmDialog.qml
- History
- Source
- Diff
/sources/gui/qml/dialogs/AlarmDialog.qml
- -1
- +1
/sources/gui/qml/dialogs/NotificationDialog.qml
- History
- Source
- Diff
/sources/gui/.../NotificationDialog.qml
- -1
- +1
/sources/gui/qml/main.qml
- History
- Source
- Diff
/sources/gui/qml/main.qml
- -12
- +12
/sources/gui/qml/pages/settings/SettingsAdvancedInstitutional.qml
- History
- Source
- Diff
/sources/.../SettingsAdvancedInstitutional.qml
- -12
- +12
/sources/gui/qml/pages/settings/SettingsCalibrationSettings.qml
- History
- Source
- Diff
/sources/.../SettingsCalibrationSettings.qml
- -12
- +12
/sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
- History
- Source
- Diff
/sources/.../SettingsInstitutionalRecord.qml
- -1
- +1
/sources/gui/qml/pages/treatment/TreatmentHDF.qml
- History
- Source
- Diff
/sources/gui/.../treatment/TreatmentHDF.qml
- -1
- +1
/sources/gui/qml/pages/treatment/TreatmentHeparin.qml
- History
- Source
- Diff
/sources/gui/.../TreatmentHeparin.qml
- -13
- +13
/sources/gui/qml/pages/treatment/TreatmentSection.qml
- History
- Source
- Diff
/sources/gui/.../TreatmentSection.qml
- -16
- +16
/sources/gui/qml/pages/treatment/TreatmentTrends.qml
- History
- Source
- Diff
/sources/gui/.../TreatmentTrends.qml
- -1
- +1
/sources/gui/qml/pages/treatment/sections/TreatmentFlows.qml
- History
- Source
- Diff
/sources/gui/.../sections/TreatmentFlows.qml
- -12
- +12
/sources/gui/qml/pages/treatment/sections/TreatmentFlowsComponent.qml
- History
- Source
- Diff
/sources/gui/.../TreatmentFlowsComponent.qml
- -1
- +1
/sources/gui/qml/pages/treatment/sections/TreatmentHDFComponent.qml
- History
- Source
- Diff
/sources/gui/.../TreatmentHDFComponent.qml
- -1
- +1
/sources/gui/qml/plugins/virtualkeyboard/layouts/fallback/symbols.qml
- History
- Source
- Diff
/sources/gui/qml/.../fallback/symbols.qml

3:04 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

2:05 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5572-1
started review

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

1:51 pm

Nicholas Ramirez

updated

updated

12:49 pm

Behrouz NematiPour

APPROVED.

APPROVED.

12:49 pm

Behrouz NematiPour

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

12:48 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
Also move the:
```
; if ( ! ok ) { goto invalid; }
```
on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-20 21:34 -0700