dd-firmware / firmware / App / Services

TDInterface.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 30 Jul 24
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Dec
1:24 pm

Dara Navaei

1:21 pm

Dara Navaei and Sean Nash

Thursday 04 Dec
5:37 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:37 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:37 pm

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

5:36 pm

Vendor - TEL - Varshini Nagabooshanam

Changed the comments

Changed the comments

5:35 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:35 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:43 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

4:43 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

4:41 pm

Sean Nash

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

4:39 pm

Sean Nash

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by D...

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment.

4:36 pm

Sean Nash

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

4:34 pm

Sean Nash

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

4:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

4:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

4:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:05 pm

Vendor - TEL - Varshini Nagabooshanam

Noted.

Noted.

4:03 pm

Vendor - TEL - Varshini Nagabooshanam

Changed this section and rewritten

Changed this section and rewritten

4:03 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:02 pm

Vendor - TEL - Varshini Nagabooshanam

Yeah, I removed this.

Yeah, I removed this.

3:59 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I used MSG_ID_AVAILABLE_2.

Yes, I used MSG_ID_AVAILABLE_2.

3:57 pm

Vendor - TEL - Varshini Nagabooshanam

Done.

Done.

3:55 pm

Vendor - TEL - Varshini Nagabooshanam

Noted.

Noted.

3:55 pm

Vendor - TEL - Varshini Nagabooshanam

Noted.

Noted.

2:31 pm

Dara Navaei

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?

2:29 pm

Dara Navaei

You don't need the if statement. The override function will check it automatically.

You don't need the if statement. The override function will check it automatically.

2:24 pm

Dara Navaei

( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already.

( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already.

2:14 pm

Dara Navaei

Please use getU32override function and then typecast it.

Please use getU32override function and then typecast it.

2:14 pm

Dara Navaei

Please use getU32override function and then typecast it.

Please use getU32override function and then typecast it.