SeansHDTestScript.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED

RESOLVED

DIALIN-DEN-2652_DG Valve Control 1 of 2
DIALIN-DEN-2652_DG Valve Control 1 of 2
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Addressed.

Addressed.

valve state will be an integer so use integer_to_bytearray().

valve state will be an integer so use integer_to_bytearray().

Addressed.

Addressed.

RESOLVED.

RESOLVED.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

Fixed.

Fixed.

Fixed.

Fixed.

See above comment

See above comment

Delete

Delete

Delete

Delete

Please use snake_case: PEP8 Function names should be lowercase, with words separated by underscores as necessary to improve readability. Variable names follow the same convention as function names.

Please use snake_case: PEP8

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

Variable names follow the same convention as function names.

It returns False otherwise, not 0

It returns False otherwise, not 0

I think this needs to be addressed by Sean.

I think this needs to be addressed by Sean.

Don't you need the first element in each tuple?

Don't you need the first element in each tuple?

Fixed.

Fixed.