CS-BUILD-0-2-4-1 CS-Build-0.2.4

closed on 19 Oct 23

Author

Reviewers

CS-Build-0.2.4

Activity

Details
Objectives
General Comments 4
Unresolved
Resolved
Number of files included: 25

cloudsync 0
- Folder cloudsync 0
  - Folder busses 0
    - File file_input_bus.py 11 Remove
    - File file_output_bus.py 6 Remove
  - Folder common 0
    - File enums.py 0 Remove
  - Folder config 0
    - File config.json 10 Remove
    - File config_INT.json 0 Remove
    - File config_QA.json 0 Remove
    - File config_STAGING.json 0 Remove
    - File treatment_report_template.json 0 Remove
  - Folder handlers 0
    - Folder incoming 0
      - File handler_dcs_to_cs.py 0 Remove
      - File handler_mft_to_cs.py 0 Remove
    - Folder outgoing 0
      - File handler_cs_to_dcs.py 3 Remove
      - File handler_cs_to_mft.py 0 Remove
    - File cs_mft_dcs_request_handler.py 9 Remove
    - File error.py 0 Remove
    - File error_handler.py 0 Remove
    - File network_request.py 0 Remove
    - File ui_cs_request_handler.py 0 Remove
    - File uics_message.py 3 Remove
  - Folder utils 0
    - File globals.py 0 Remove
    - File heartbeat.py 0 Remove
    - File helpers.py 6 Remove
    - File reachability.py 7 Remove
    - File singleton.py 0 Remove
- File cloud_sync.py 6 Remove
- File cs.py 9 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	2h 9m	45	Radu: "The Team is in the progress of updating and refact...
Dara Navaei	Reviewer - 1% reviewed	23m	1	RESOLVED
Sean Nash	Reviewer - 2% reviewed	1h 2m	28	RESOLVED.
jishii (deleted user)	Reviewer - 2% reviewed	1h 27m
Michael Garthwaite	Reviewer - 0% reviewed	21m
Tiffany Mejia	Reviewer - 2% reviewed	9m
Total		5h 33m	74

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
DEN-14564

#permalink

General Comments

Behrouz NematiPour

Update all the function docstrings?

12 Dec 22

Behrouz NematiPour

Resolved

13 Jan 23

Behrouz NematiPour

RESOLVED. It has been addressed in other comments.

RESOLVED.
It has been addressed in other comments.

13 Jan 23

Behrouz NematiPour

Update the code base in regards to the Diality Python coding standard. To be ...

Update the code base in regards to the Diality Python coding standard.
To be included :
X:\Engineering\Denali\06- Software Design\Software Documentation\Coding Standards
SOP-0058, Software Coding Standards, Python, Rev. 01.docx

12 Dec 22

Behrouz NematiPour

Resolved

13 Jan 23

Behrouz NematiPour

RESOLVED It has been addressed mostly and has some extra comments about that.

RESOLVED
It has been addressed mostly and has some extra comments about that.

13 Jan 23

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CS-BUILD-0-2-4-1

CS-Build-0.2.4

CS-BUILD-0-2-4-1 74

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Log time

CS-Build-0.2.4

CS-BUILD-0-2-4-1 74

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Log time