CS-Build-0.2.4

Activity

CS-BUILD-0-2-4-1 74

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 9m 45 Radu: "The Team is in the progress of updating and refact...
    Reviewer - 1% reviewed 23m 1 RESOLVED
    Reviewer - 2% reviewed 1h 2m 28 RESOLVED.
    jishii  (deleted user)
    Reviewer - 2% reviewed 1h 27m    
    Reviewer - 0% reviewed 21m    
    Reviewer - 2% reviewed 9m    
    Total   5h 33m 74  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    DEN-14564
    #permalink

    General Comments

    Behrouz NematiPour

    Update all the function docstrings?

    Update all the function docstrings?

    Behrouz NematiPour

    RESOLVED. It has been addressed in other comments.

    RESOLVED.
    It has been addressed in other comments.

    Behrouz NematiPour

    Update the code base in regards to the Diality Python coding standard. To be ...

    Update the code base in regards to the Diality Python coding standard.
    To be included :
    X:\Engineering\Denali\06- Software Design\Software Documentation\Coding Standards
    SOP-0058, Software Coding Standards, Python, Rev. 01.docx

    Behrouz NematiPour

    RESOLVED It has been addressed mostly and has some extra comments about that.

    RESOLVED
    It has been addressed mostly and has some extra comments about that.

    /cloudsync/busses/file_input_bus.py Added 11
    /cloudsync/busses/file_output_bus.py Added 6
    /cloudsync/common/enums.py Added
    /cloudsync/config/config.json Added 10
    /cloudsync/config/config_INT.json Added
    /cloudsync/config/config_QA.json Added
    /cloudsync/config/config_STAGING.json Added
    Open in IDE #permalink
    /cloudsync/config/treatment_report_template.json Added
    /cloudsync/.../incoming/handler_dcs_to_cs.py Added
    Open in IDE #permalink
    /cloudsync/.../incoming/handler_mft_to_cs.py Added
    Open in IDE #permalink
    /cloudsync/.../outgoing/handler_cs_to_dcs.py Added 3
    /cloudsync/.../outgoing/handler_cs_to_mft.py Added
    /cloudsync/handlers/cs_mft_dcs_request_handler.py Added 9
    /cloudsync/handlers/error.py Added
    Open in IDE #permalink
    /cloudsync/handlers/error_handler.py Added
    Open in IDE #permalink
    /cloudsync/handlers/network_request.py Added
    Open in IDE #permalink
    /cloudsync/handlers/ui_cs_request_handler.py Added
    /cloudsync/handlers/uics_message.py Added 3
    Open in IDE #permalink
    /cloudsync/utils/globals.py Added
    /cloudsync/utils/heartbeat.py Added
    Open in IDE #permalink
    /cloudsync/utils/helpers.py Added 6
    /cloudsync/utils/reachability.py Added 7
    /cloudsync/utils/singleton.py Added
    Open in IDE #permalink
    /cloud_sync.py Added 6
    /cs.py Added 9

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time