DIALIN-2 Dialin DEN-4589_Sprint_26

closed on 30 Sep 20

Author

Moderator

Reviewers

Dialin DEN-4589_Sprint_26

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 24

dialin 0
- Folder dialin 0
  - Folder dg 0
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File ro_pump.py 0 Remove
    - File temperature_sensors.py 0 Remove
    - File valves.py 0 Remove
  - Folder hd 0
    - File alarms.py 0 Remove
    - File blood_flow.py 0 Remove
    - File buttons.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File watchdog.py 0 Remove
  - File version.py 0 Remove
- Folder docs/source 0
  - File conf.py 0 Remove
- Folder tools 0
  - File install_to_venv.sh 0 Remove
  - File run_static_code_analysis.sh 0 Remove
- File requirements.txt 3 Remove
- File setup.py 0 Remove
- File version.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author & Moderator	48m	2	1 - pip uses requirements.txt to install dependencies. Se...
Behrouz NematiPour	Reviewer - Complete	19m	4	Good, So please consider cleaning up used libraries perio...
Sean Nash	Reviewer - Complete	4m
Total		1h 12m	6

Linked issues
- DEN-4589

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

Why this code review starts with "UI_" it's all Dialin. Shouldn't it be start...

Why this code review starts with "UI_" it's all Dialin.
Shouldn't it be started with Dialin?

08 Sep 20

Behrouz NematiPour

Resolved

30 Sep 20

plucia (deleted user)

I have updated it so it says Dialin now.

09 Sep 20

Behrouz NematiPour

RESOLVED

30 Sep 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-2

Dialin DEN-4589_Sprint_26

DIALIN-2 6

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Log time

Dialin DEN-4589_Sprint_26

DIALIN-2 6

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Log time