DIALIN-DEN-14786-1 DIALIN-DEN-14786_Dialin Not Tread Safe With Canbus Messages

closed on 10 Mar 23

Author

Moderator

Reviewers

DIALIN-DEN-14786_Dialin Not Tread Safe With Canbus Messages

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 73

dialin 0
- Folder dialin 0
  - Folder common 0
    - File msg_ids.py 0 Remove
  - Folder dg 0
    - File accelerometer.py 0 Remove
    - File alarms.py 0 Remove
    - File calibration_record.py 0 Remove
    - File chemical_disinfect.py 0 Remove
    - File chemical_disinfect_flush.py 0 Remove
    - File concentrate_pumps.py 0 Remove
    - File conductivity_sensors.py 0 Remove
    - File cpld.py 0 Remove
    - File dialysate_fill.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File events.py 0 Remove
    - File fans.py 0 Remove
    - File flow_sensors.py 3 Remove
    - File fluid_leak.py 0 Remove
    - File flush.py 0 Remove
    - File gen_idle.py 0 Remove
    - File heat_disinfect.py 0 Remove
    - File heat_disinfect_active_cool.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_pump.py 0 Remove
    - File rtc.py 0 Remove
    - File samplewater.py 0 Remove
    - File scheduled_runs_record.py 0 Remove
    - File service_record.py 0 Remove
    - File sw_configs.py 0 Remove
    - File switches.py 0 Remove
    - File system_record.py 0 Remove
    - File temperatures.py 0 Remove
    - File thermistors.py 0 Remove
    - File usage_info_record.py 0 Remove
    - File uv_reactors.py 0 Remove
    - File valves.py 0 Remove
    - File voltages.py 0 Remove
  - Folder hd 0
    - File accelerometer.py 0 Remove
    - File air_bubbles.py 0 Remove
    - File air_pump.py 0 Remove
    - File air_trap.py 0 Remove
    - File alarms.py 0 Remove
    - File battery.py 0 Remove
    - File blood_flow.py 0 Remove
    - File blood_leak.py 0 Remove
    - File buttons.py 0 Remove
    - File calibration_record.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File fans.py 0 Remove
    - File fluid_leak.py 0 Remove
    - File hd_events.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File post_treatment.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File pretreatment.py 0 Remove
    - File reservoirs.py 0 Remove
    - File rtc.py 0 Remove
    - File service_record.py 0 Remove
    - File sw_configs.py 0 Remove
    - File switches.py 0 Remove
    - File syringe_pump.py 0 Remove
    - File system_record.py 0 Remove
    - File temperatures.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File valves.py 0 Remove
    - File voltages.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder ui 0
    - File dg_simulator.py 0 Remove
    - File hd_simulator.py 0 Remove
- Folder tests/unit_tests 0
  - File test_ui_proxy.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	25m	1	Fixed. Thanks!
Sean Nash	Reviewer - Complete	10m	2	RESOLVED.
Dara Navaei	Reviewer - Complete	1h 2m
Behrouz NematiPour	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 16% reviewed	11m
jishii (deleted user)	Reviewer - 36% reviewed	28m
Total		2h 19m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-14786-1

DIALIN-DEN-14786_Dialin Not Tread Safe With Canbus Messages

DIALIN-DEN-14786-1 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-14786_Dialin Not Tread Safe With Canbus Messages

DIALIN-DEN-14786-1 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time