DIALIN-DEN-2379-1 DIALIN-DEN-2379_DG Dialysate Temperature (1 of 2)

closed on 17 Jul 20

Author

Moderator

Reviewers

DIALIN-DEN-2379_DG Dialysate Temperature (1 of 2)

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 19

dialin 0
- Folder dialin 0
  - Folder dg 0
    - File __init__.py 0 Remove
    - File dialysate_generator.py 4 Remove
    - File drain_pump.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heaters.py 6 Remove
    - File pressures.py 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_pump.py 0 Remove
    - File temperature_sensors.py 22 Remove
  - Folder hd 0
    - File alarms.py 0 Remove
    - File buttons.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File rtc.py 3 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File watchdog.py 0 Remove
  - Folder utils 0
    - File base.py 0 Remove
- Folder tests 0
  - File dg_heaters_test.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	18m	12	Eventually yes. I have a TODO note to add RTC to DG as well.
Sean Nash	Reviewer - Complete	16m	5	Dara resolved in another branch. RESOLVED.
plucia (deleted user)	Reviewer - Complete	44m	20	RESOLVED
pmontazemi (deleted user)	Reviewer - 2% reviewed	19m
Total		1h 39m	37

Linked issues
- DEN-2379

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

plucia (deleted user)

I think other commits of mine and others are still included in this review th...

I think other commits of mine and others are still included in this review that aren't related. Can you point me to the files that you changed?

01 Jul 20

Dara Navaei

Ok, please review heaters.py and temperature_sensors.py

01 Jul 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-2379-1

DIALIN-DEN-2379_DG Dialysate Temperature (1 of 2)

DIALIN-DEN-2379-1 37

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Dara Navaei

Log time

DIALIN-DEN-2379_DG Dialysate Temperature (1 of 2)

DIALIN-DEN-2379-1 37

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

Dara Navaei

Log time