DIALIN-DEN-7792-1 DIALIN-DEN-7792_Sprint 42

closed on 22 Apr 21

Author

Reviewers

DIALIN-DEN-7792_Sprint 42

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 30

dialin 0
- Folder dialin 0
  - Folder common 0
    - File AlarmIds.txt 0 Remove
    - File __init__.py 0 Remove
    - File alarm_defs.py 0 Remove
    - File alarm_priorities.py 0 Remove
    - File msg_defs.py 0 Remove
    - File msg_ids.py 0 Remove
    - File ui_defs.py 0 Remove
  - Folder dg 0
    - File fans.py 0 Remove
    - File hd_proxy.py 3 Remove
    - File ro_pump.py 0 Remove
    - File uv_reactors.py 0 Remove
  - Folder hd 0
    - File air_trap.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 3 Remove
    - File valves.py 0 Remove
  - Folder ui 0
    - File __init__.py 0 Remove
    - File dg_simulator.py 0 Remove
    - File hd_simulator.py 0 Remove
- Folder tests/unit_tests 0
  - File test_constructors.py 0 Remove
  - File test_enums.py 0 Remove
  - File test_imports.py 0 Remove
  - File test_msg_ids.py 0 Remove
- Folder tools 0
  - File build_alarm_defs.py 0 Remove
  - File build_common_defs.py 3 Remove
  - File gen_alarm_ids.sh 0 Remove
  - File gen_common_defs.sh 3 Remove
  - File setup_env.sh 3 Remove
  - File setup_environment.sh 0 Remove
- File requirements.txt 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author	26m	5	Done
pmontazemi (deleted user)	Reviewer - Complete	5m
qnguyen (deleted user)	Reviewer - Complete	27m	10	RESOLVED.
Sean Nash	Reviewer - Complete	6m
Total		1h 6m	15

Linked issues
- DEN-5980
- DEN-7792
- DIAL-75
- DIAL-79
- DIAL-80
- DIAL-88

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-7792-1

DIALIN-DEN-7792_Sprint 42

DIALIN-DEN-7792-1 15

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-7792_Sprint 42

DIALIN-DEN-7792-1 15

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time