DIALIN-PENDING-APPROAVAL-1 DIALIN_Pending from DG code review

closed on 22 Jan 20

Author

Moderator

Reviewers

DIALIN_Pending from DG code review

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 4

dialin 0
- Folder Miscellaneous 0
  - File HD_TestScript.py 3 Remove
- File DialityCoreCanProtocol.py 3 Remove
- File DialysateGenerator.py 0 Remove
- File HemodialysisDevice.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	16m	3	Done
Sean Nash	Reviewer - Complete	17m	2	RESOLVED.
Behrouz NematiPour	Reviewer - 0% reviewed
pmontazemi (deleted user)	Reviewer - Complete	8m	2	RESOLVED.
lbaloa (deleted user)	Reviewer - 11% reviewed	17m	2	change to \param and \return
Total		1h	9

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

lbaloa (deleted user)

We need HD_TestScript.py to be move to a pytest type of function on the next ...

We need HD_TestScript.py to be move to a pytest type of function on the next revision of this software.

21 Jan 20

Sean Nash

Resolved

22 Jan 20

Dara Navaei

We will do it on the next revision

21 Jan 20

Sean Nash

RESOLVED.

22 Jan 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-PENDING-APPROAVAL-1

DIALIN_Pending from DG code review

DIALIN-PENDING-APPROAVAL-1 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Dara Navaei

Sean Nash

Log time

DIALIN_Pending from DG code review

DIALIN-PENDING-APPROAVAL-1 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Dara Navaei

Sean Nash

Log time