HD-DEN-13598-2 HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

closed on 27 Sep 22

Author

Moderator

Reviewers

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

Activity

Details
Objectives
General Comments 4
Unresolved
Resolved
Number of files included: 44

hdfirmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File BloodFlow.c 0 Remove
      - File BloodLeak.c 0 Remove
      - File BloodLeak.h 0 Remove
      - File DGInterface.c 27 Remove
      - File DGInterface.h 0 Remove
      - File DialInFlow.c 0 Remove
      - File DialOutFlow.c 0 Remove
      - File Fans.c 0 Remove
      - File PresOccl.c 0 Remove
      - File PresOccl.h 0 Remove
      - File SyringePump.c 0 Remove
      - File SyringePump.h 0 Remove
      - File Temperatures.c 3 Remove
      - File Temperatures.h 0 Remove
      - File Valves.c 0 Remove
      - File Voltages.c 0 Remove
    - Folder Drivers 0
      - File Battery.c 0 Remove
      - File InternalADC.c 0 Remove
      - File SafetyShutdown.c 0 Remove
    - Folder Modes 0
      - File BloodPrime.c 0 Remove
      - File Dialysis.c 0 Remove
      - File ModeFault.c 0 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModeStandby.c 0 Remove
      - File ModeTreatmentParams.c 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
      - File Prime.c 7 Remove
      - File Rinseback.c 0 Remove
      - File SelfTests.c 2 Remove
      - File TreatmentStop.c 0 Remove
    - Folder Services 0
      - File AlarmMgmt.c 0 Remove
      - File AlarmMgmt.h 0 Remove
      - File AlarmMgmtSWFaults.h 0 Remove
      - File CommBuffers.c 0 Remove
      - File FPGA.c 5 Remove
      - File SystemComm.c 5 Remove
      - File SystemCommMessages.c 3 Remove
      - File SystemCommMessages.h 0 Remove
    - Folder Tasks 0
      - File TaskBG.c 0 Remove
      - File TaskGeneral.c 5 Remove
      - File TaskPriority.c 0 Remove
    - File HDCommon.h 0 Remove
  - Folder source 0
    - File sys_main.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dong Nguyen	Author & Moderator	2h 39m	12	This comment looks like the same as the previous one? I a...
Sean Nash	Reviewer - Complete	1h 25m	20	RESOLVED in CODE WALKTHROUGH.
Darren Cox	Reviewer - Complete	24m	6	RESOLVED IN CODE WALKTHROUGH
Michael Garthwaite	Reviewer - 0% reviewed	1h 3m	10	Remove blank line.
wbracken (deleted user)	Reviewer - Complete	1h 40m	12	RESOLVED IN CODE WALKTHROUGH
Dara Navaei	Reviewer - 0% reviewed	7m	1	I added the common branch to this code review.
Total		7h 21m	61

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Michael Garthwaite

Sean Nash Dara Navaei Does this code review also need the common repo as wel...

Sean Nash Dara Navaei

Does this code review also need the common repo as well? There are changes within this branch that look like they have changes in alarmdefs.h.

31 Aug 22

Sean Nash

Resolved

26 Sep 22

Sean Nash

common and fwcommon repos are covered in the 13598 DG code review so not need...

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

22 Sep 22

Dara Navaei

I added the common branch to this code review.

22 Sep 22

Sean Nash

RESOLVED in CODE WALKTHROUGH

26 Sep 22

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-DEN-13598-2

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

HD-DEN-13598-2 61

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Sean Nash

Dara Navaei

Sean Nash

Log time

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

HD-DEN-13598-2 61

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Sean Nash

Dara Navaei

Sean Nash

Log time