HD-MASTER-1 HD Master Branch Review

closed on 07 Dec 19

Author

Reviewers

HD Master Branch Review

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 189

HDProject (master) 0
- Folder .launches 0
  - File HD.launch 0 Remove
  - File SeanTest.launch 0 Remove
- Folder .settings 0
  - File org.eclipse.cdt.codan.core.prefs 0 Remove
  - File org.eclipse.cdt.debug.core.prefs 0 Remove
  - File org.eclipse.core.resources.prefs 0 Remove
- Folder App 0
  - Folder Contollers 0
    - File AlarmLamp.c 17 Remove
    - File AlarmLamp.h 0 Remove
    - File Buttons.c 4 Remove
    - File Buttons.h 0 Remove
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
    - File WatchdogMgmt.c 0 Remove
    - File WatchdogMgmt.h 0 Remove
  - Folder Drivers 0
    - File CPLD.c 2 Remove
    - File CPLD.h 3 Remove
    - File SafetyShutdown.c 9 Remove
    - File SafetyShutdown.h 0 Remove
  - Folder Modes 0
    - File ModeFault.c 1 Remove
    - File ModeFault.h 0 Remove
    - File ModeInitPOST.c 0 Remove
    - File ModeInitPOST.h 0 Remove
    - File ModeOpParams.c 0 Remove
    - File ModeOpParams.h 0 Remove
    - File ModePostTreat.c 0 Remove
    - File ModePostTreat.h 0 Remove
    - File ModePreTreat.c 0 Remove
    - File ModePreTreat.h 0 Remove
    - File ModePrescription.c 0 Remove
    - File ModePrescription.h 0 Remove
    - File ModeService.c 0 Remove
    - File ModeService.h 0 Remove
    - File ModeStandby.c 0 Remove
    - File ModeStandby.h 0 Remove
    - File ModeTreatment.c 1 Remove
    - File ModeTreatment.h 0 Remove
    - File OperationModes.c 0 Remove
    - File OperationModes.h 3 Remove
  - Folder Services 0
    - File SafetyShutdown.c 0 Remove
    - File SafetyShutdown.h 0 Remove
    - File Timers.c 0 Remove
    - File Timers.h 0 Remove
    - File WatchdogMgmt.c 0 Remove
    - File WatchdogMgmt.h 0 Remove
  - Folder Tasks 0
    - File TaskBG.c 0 Remove
    - File TaskBG.h 0 Remove
    - File TaskGeneral.c 0 Remove
    - File TaskGeneral.h 0 Remove
    - File TaskPriority.c 0 Remove
    - File TaskPriority.h 0 Remove
    - File TaskTimer.c 0 Remove
    - File TaskTimer.h 0 Remove
  - File Common.h 0 Remove
- Folder Debug 0
  - Folder App 0
    - Folder Contollers 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
    - Folder Drivers 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
    - Folder Modes 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
    - Folder Tasks 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
  - Folder source 0
    - File subdir_rules.mk 0 Remove
    - File subdir_vars.mk 0 Remove
  - File HD.map 0 Remove
  - File HD.out 0 Remove
  - File HD_linkInfo.xml 0 Remove
  - File ccsObjs.opt 0 Remove
  - File makefile 0 Remove
  - File objects.mk 0 Remove
  - File sources.mk 0 Remove
- Folder include 0
  - File Device_RM46.h 0 Remove
  - File Device_header.h 0 Remove
  - File Device_types.h 0 Remove
  - File MemMap.h 0 Remove
  - File adc.h 0 Remove
  - File can.h 0 Remove
  - File crc.h 0 Remove
  - File dcc.h 0 Remove
  - File ecap.h 0 Remove
  - File emac.h 0 Remove
  - File eqep.h 0 Remove
  - File errata_SSWF021_45.h 0 Remove
  - File errata_SSWF021_45_defs.h 0 Remove
  - File esm.h 0 Remove
  - File etpwm.h 0 Remove
  - File fee_interface.h 0 Remove
  - File gio.h 0 Remove
  - File hal_stdtypes.h 0 Remove
  - File het.h 0 Remove
  - File htu.h 0 Remove
  - File hw_emac.h 0 Remove
  - File hw_emac_ctrl.h 0 Remove
  - File hw_mdio.h 0 Remove
  - File hw_reg_access.h 0 Remove
  - File hw_usb.h 0 Remove
  - File i2c.h 0 Remove
  - File lin.h 0 Remove
  - File mdio.h 0 Remove
  - File mibspi.h 0 Remove
  - File phy_dp83640.h 0 Remove
  - File pinmux.h 0 Remove
  - File pom.h 0 Remove
  - File reg_adc.h 0 Remove
  - File reg_can.h 0 Remove
  - File reg_crc.h 0 Remove
  - File reg_dcc.h 0 Remove
  - File reg_dma.h 0 Remove
  - File reg_ecap.h 0 Remove
  - File reg_efc.h 0 Remove
  - File reg_eqep.h 0 Remove
  - File reg_esm.h 0 Remove
  - File reg_etpwm.h 0 Remove
  - File reg_flash.h 0 Remove
  - File reg_gio.h 0 Remove
  - File reg_het.h 0 Remove
  - File reg_htu.h 0 Remove
  - File reg_i2c.h 0 Remove
  - File reg_lin.h 0 Remove
  - File reg_mibspi.h 0 Remove
  - File reg_pbist.h 0 Remove
  - File reg_pcr.h 0 Remove
  - File reg_pinmux.h 0 Remove
  - File reg_pmm.h 0 Remove
  - File reg_pom.h 0 Remove
  - File reg_rti.h 0 Remove
  - File reg_sci.h 0 Remove
  - File reg_spi.h 0 Remove
  - File reg_stc.h 0 Remove
  - File reg_system.h 0 Remove
  - File reg_tcram.h 0 Remove
  - File reg_vim.h 0 Remove
  - File rti.h 0 Remove
  - File sci.h 0 Remove
  - File spi.h 0 Remove
  - File std_nhet.h 0 Remove
  - File sys_common.h 0 Remove
  - File sys_core.h 0 Remove
  - File sys_dma.h 0 Remove
  - File sys_mpu.h 0 Remove
  - File sys_pcr.h 0 Remove
  - File sys_pmm.h 0 Remove
  - File sys_pmu.h 0 Remove
  - File sys_selftest.h 0 Remove
  - File sys_vim.h 0 Remove
  - File system.h 0 Remove
  - File ti_fee.h 0 Remove
  - File ti_fee_cfg.h 0 Remove
  - File ti_fee_types.h 0 Remove
  - File usb-ids.h 0 Remove
  - File usb.h 0 Remove
  - File usb_serial_structs.h 0 Remove
  - File usbcdc.h 0 Remove
  - File usbdcdc.h 0 Remove
  - File usbdevice.h 0 Remove
  - File usbdevicepriv.h 0 Remove
  - File usblib.h 0 Remove
- Folder source 0
  - File can.c 0 Remove
  - File dabort.asm 0 Remove
  - File errata_SSWF021_45.c 0 Remove
  - File esm.c 0 Remove
  - File gio.c 0 Remove
  - File lin.c 0 Remove
  - File mibspi.c 0 Remove
  - File notification.c 0 Remove
  - File pinmux.c 0 Remove
  - File rti.c 0 Remove
  - File sci.c 0 Remove
  - File sys_core.asm 0 Remove
  - File sys_dma.c 0 Remove
  - File sys_intvecs.asm 0 Remove
  - File sys_link.cmd 0 Remove
  - File sys_main.c 0 Remove
  - File sys_mpu.asm 0 Remove
  - File sys_pcr.c 0 Remove
  - File sys_phantom.c 0 Remove
  - File sys_pmm.c 0 Remove
  - File sys_pmu.asm 0 Remove
  - File sys_selftest.c 0 Remove
  - File sys_startup.c 0 Remove
  - File sys_vim.c 0 Remove
  - File system.c 0 Remove
- Folder targetConfigs 0
  - File RM46L852.ccxml 0 Remove
  - File readme.txt 0 Remove
- File .ccsproject 0 Remove
- File .cproject 0 Remove
- File .gitignore 0 Remove
- File .project 0 Remove
- File HD.dil 0 Remove
- File HD.hcg 0 Remove
- File irqDispatch_c.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sean Nash	Author	50m	9	I abbreviated them to a fixed 4 characters to help make t...
pmontazemi (deleted user)	Reviewer - Complete	42m	7	RESOLVED in CODE WALKTHROUGH.
Dara Navaei	Reviewer - Complete	2h 58m	7	RESOLVED
lbaloa (deleted user)	Reviewer - Complete	1h 14m	17	RESOLVED IN CODE WALKTHROUGH
Total		5h 46m	40

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Repository HDProject does not exist

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-MASTER-1

HD Master Branch Review

HD-MASTER-1 40

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

HD Master Branch Review

HD-MASTER-1 40

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time