HD-SPR3-1 HD Sprint3 Branch Review

closed on 07 Dec 19

Author

Reviewers

HD Sprint3 Branch Review

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 36

HDProject (sprint3) 0
- Folder App 0
  - Folder Contollers 0
    - File AlarmLamp.c 0 Remove
    - File Buttons.c 8 Remove
    - File Buttons.h 0 Remove
  - Folder Drivers 0
    - File CPLD.c 10 Remove
    - File CPLD.h 3 Remove
  - Folder Services 0
    - File CommBuffers.c 24 Remove
    - File CommBuffers.h 0 Remove
    - File MsgQueues.c 6 Remove
    - File MsgQueues.h 0 Remove
    - File SystemComm.c 12 Remove
    - File SystemComm.h 0 Remove
    - File SystemCommMessages.c 0 Remove
    - File SystemCommMessages.h 0 Remove
    - File Timers.c 0 Remove
    - File WatchdogMgmt.c 3 Remove
  - Folder Tasks 0
    - File TaskBG.c 0 Remove
    - File TaskGeneral.c 0 Remove
  - File Common.h 0 Remove
- Folder Debug 0
  - Folder App 0
    - Folder Contollers 0
      - File subdir_rules.mk 0 Remove
    - Folder Drivers 0
      - File subdir_rules.mk 0 Remove
    - Folder Modes 0
      - File subdir_rules.mk 0 Remove
    - Folder Tasks 0
      - File subdir_rules.mk 0 Remove
  - Folder source 0
    - File subdir_rules.mk 0 Remove
  - File ccsObjs.opt 0 Remove
  - File makefile 0 Remove
- Folder include 0
  - File can.h 0 Remove
  - File sys_vim.h 0 Remove
- Folder source 0
  - File can.c 3 Remove
  - File notification.c 0 Remove
  - File rti.c 0 Remove
  - File sys_link.cmd 0 Remove
  - File sys_main.c 0 Remove
  - File sys_startup.c 0 Remove
  - File sys_vim.c 0 Remove
- File .cproject 0 Remove
- File HD.dil 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sean Nash	Author	1h 26m	23	Agreed. See HD-SPR4-1 review for fix.
Dara Navaei	Reviewer - Complete	2h 3m	3	RESOLVED in CODE WALKTHROUGH
pmontazemi (deleted user)	Reviewer - Complete	1h	1	This is CLASS C code that needs to be reviewed in a group...
lbaloa (deleted user)	Reviewer - Complete	1h 29m	44	RESOLVED IN CODE WALKTHROUGH
Total		5h 59m	71

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

lbaloa (deleted user)

We might want to change Contollers directory to Controllers

17 Oct 19

lbaloa

(deleted user)

Resolved

22 Oct 19

lbaloa (deleted user)

RESOLVED IN CODE WALKTHROUGH

22 Oct 19

Repository HDProject does not exist

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-SPR3-1

HD Sprint3 Branch Review

HD-SPR3-1 71

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

lbaloa (deleted user)

Log time

HD Sprint3 Branch Review

HD-SPR3-1 71

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

lbaloa (deleted user)

Log time