SRVC-DEN-6838-1 SRVC-DEN-6838_Service App Master Branch

closed on 31 Mar 21

Author

Moderator

Reviewers

SRVC-DEN-6838_Service App Master Branch

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 52

firmwarecontroller (DEN-6838_debug) 0
- Folder fwcontroller 0
  - Folder base 0
    - File __init__.py 0 Remove
    - File fw_controller.py 0 Remove
    - File fw_controller_widget.py 0 Remove
    - File tab_widget.py 0 Remove
    - File widget.py 0 Remove
  - Folder dg 0
    - File __init__.py 0 Remove
    - File widget.py 0 Remove
  - Folder dg_pumps 0
    - File __init__.py 0 Remove
  - Folder dg_valves 0
    - File __init__.py 0 Remove
  - Folder globals 0
    - File observer.py 0 Remove
  - Folder hd 0
    - File __init__.py 0 Remove
    - File hd_sub_module.py 0 Remove
    - File hd_sub_module_monitor.py 0 Remove
    - File monitor.py 0 Remove
    - File widget.py 0 Remove
  - Folder hd_blood_flow 0
    - File __init__.py 0 Remove
    - File widget.py 0 Remove
  - Folder info 0
    - File __init__.py 0 Remove
    - File dg.py 0 Remove
    - File hd.py 0 Remove
  - Folder main 0
    - File login.py 0 Remove
    - File main.py 0 Remove
  - Folder submodule 0
    - File __init__.py 0 Remove
  - File __init__.py 0 Remove
- Folder tools 0
  - File bring_can_interface_down.sh 0 Remove
  - File check_setup.sh 0 Remove
  - File create_dialin_link.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_virtual_can.sh 0 Remove
  - File windows_setup.bat 0 Remove
- File .gitignore 0 Remove
- File setup.bat 0 Remove
- File setup.sh 0 Remove
firmwarecontroller (master) 0
- Folder tools 0
  - File setup_env.sh 0 Remove
- File requirements.txt 0 Remove
firmwarecontroller (staging) 0
- Folder fwcontroller 0
  - Folder base 0
    - File base_widget.py 0 Remove
  - Folder dg_pumps 0
    - File widget.py 0 Remove
  - Folder dg_valves 0
    - File widget.py 0 Remove
  - Folder globals 0
    - File __init__.py 0 Remove
    - File utils.py 0 Remove
  - Folder info 0
    - File system.py 0 Remove
  - Folder main 0
    - File __init__.py 0 Remove
    - File dg.py 0 Remove
    - File hd.py 0 Remove
    - File main_widget.py 0 Remove
    - File main_window.py 0 Remove
    - File ui.py 0 Remove
  - Folder submodule 0
    - File submodule_control.py 0 Remove
    - File submodule_monitor.py 0 Remove
- Folder tools 0
  - File setup_env.sh 0 Remove
- File main.py 0 Remove
- File requirements.txt 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
plucia (deleted user)	Author & Moderator	8m
Sean Nash	Reviewer - 100% reviewed	1m
Behrouz NematiPour	Reviewer - Complete	9m
pmontazemi (deleted user)	Reviewer - Complete	12m
Total		31m	0

Linked issues
- DEN-7043

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Repository firmwarecontroller does not exist

/fwcontroller/base/fw_controller_widget.py Deleted

Repository firmwarecontroller does not exist

/fwcontroller/hd/hd_sub_module_monitor.py Deleted

Repository firmwarecontroller does not exist

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SRVC-DEN-6838-1

SRVC-DEN-6838_Service App Master Branch

SRVC-DEN-6838-1 0

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

SRVC-DEN-6838_Service App Master Branch

SRVC-DEN-6838-1 0

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time