UI-DEN-13726-2 Build_Issue_Merging__DEN-12716-UI_BN_S70__to__staging

closed on 13 Sep 22

Author

Moderator

Reviewers

Build_Issue_Merging__DEN-12716-UI_BN_S70tostaging

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 13

application 0
- Folder sources 0
  - Folder gui 0
    - Folder qml/pages 0
      - Folder pretreatment 0
        
        File PreTreatmentPrimeStack.qml 0 Remove
      - File MainStack.qml 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model/hd 0
    - Folder adjustment/treatment 0
      - File MTreatmentAdjustUltrafiltrationStateResponse.cpp 0 Remove
      - File MTreatmentAdjustUltrafiltrationStateResponse.h 0 Remove
    - Folder alarm 0
      - File MAlarmMapping.cpp 0 Remove
  - Folder view/hd 0
    - Folder adjustment/treatment 0
      - File VTreatmentAdjustmentUltrafiltrationState.cpp 0 Remove
    - Folder data 0
      - Folder pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
        
        File VPreTreatmentStatesData.h 0 Remove
      - Folder treatment 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
- Folder unittests 0
  - File tst_models.cpp 0 Remove
- File AlarmMapping.csv 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Behrouz NematiPour	Author & Moderator	10m
Dara Navaei	Reviewer - 0% reviewed	1m
Sean Nash	Reviewer - Complete	2m
Tiffany Mejia	Reviewer - Complete	4m
Michael Garthwaite	Reviewer - Complete	11m
Total		30m	0

Linked issues
- DEN-12716
- DEN-13845

#permalink

Objectives

after the code review completion of the branch S70, it couldn't be merged into the staging due to some changes on the "common" repository.
Those issues have been fixed to be able to merge.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-13726-2

Build_Issue_Merging__DEN-12716-UI_BN_S70tostaging

UI-DEN-13726-2 0

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

Build_Issue_Merging__DEN-12716-UI_BN_S70__to__staging

UI-DEN-13726-2 0

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

Build_Issue_Merging__DEN-12716-UI_BN_S70tostaging