UI-DEN-14947-4 UI-DEN-14947_UI [Misc Minor Bugs] - Ready

closed on 19 Apr 23

Author

Moderator

Reviewers

jishii (deleted user)
Sean Nash
Dara Navaei
jreaume (deleted user)

UI-DEN-14947_UI [Misc Minor Bugs] - Ready

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 7

application 0
- Folder sources 0
  - Folder gui/qml 0
    - Folder components 0
      - File RangeRect.qml 0 Remove
    - File main.qml 0 Remove
  - Folder view/hd/adjustment/common 0
    - File VCommonAdjustmentVitals.cpp 0 Remove
    - File VCommonAdjustmentVitals.h 0 Remove
  - File ApplicationPost.cpp 0 Remove
  - File ApplicationPost.h 0 Remove
common 0
- File AlarmDefs.h 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
vduong (deleted user)	Author & Moderator	40m	1	I moved it to the end of the table
Behrouz NematiPour	Reviewer - Complete	15m	1	this CR needs Sean Nash, and/or Dara Navaei review for th...
Michael Garthwaite	Reviewer - 92% reviewed	1m
Tiffany Mejia	Reviewer - 92% reviewed	6m
jishii (deleted user)	Reviewer - 92% reviewed	4m
Sean Nash	Reviewer - Complete	8m	3	RESOLVED.
Dara Navaei	Reviewer - Complete	4m
jreaume (deleted user)	Reviewer - 0% reviewed
Total		1h 20m	5

#permalink

Objectives

Smaller bug fixes / code changes:

Increase gap of slider value min/max
Add year check in POST
Add treatment vitals timer text in main.qml header for debugging purposes

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

this CR needs Sean Nash, and/or Dara Navaei review for the AlarmDefs.h.

19 Apr 23

Sean Nash

Resolved

19 Apr 23

Sean Nash

I reviewed. One comment re: improper placement in table. RESOLVED.

I reviewed. One comment re: improper placement in table.
RESOLVED.

19 Apr 23

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-14947-4

UI-DEN-14947_UI [Misc Minor Bugs] - Ready

UI-DEN-14947-4 5

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Sean Nash

Log time

UI-DEN-14947_UI [Misc Minor Bugs] - Ready

UI-DEN-14947-4 5

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Sean Nash

Log time