UI-DEN-4964-1 UI-DEN-4964_UI Messaging Version Accelometer

closed on 10 Feb 21

Author

Reviewers

UI-DEN-4964_UI Messaging Version Accelometer

Activity

Details
Objectives
General Comments 5
Unresolved
Resolved
Number of files included: 52

application 0
- Folder sources 0
  - Folder canbus 0
    - File messagedispatcher.cpp 0 Remove
    - File messagedispatcher.h 0 Remove
    - File messageglobals.h 6 Remove
    - File messageinterpreter.cpp 5 Remove
    - File messageinterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File DebugDataColumn.qml 0 Remove
      - Folder pages 0
        
        File ManagerHome.qml 9 Remove
      - File main.qml 0 Remove
    - File guiglobals.cpp 0 Remove
    - File guiglobals.h 0 Remove
  - Folder model 0
    - Folder dg 0
      - Folder adjustment 0
        
        File MTreatmentAdjustDGVersionsResponse.cpp 0 Remove
        
        File MTreatmentAdjustDGVersionsResponse.h 6 Remove
      - Folder data 0
        
        File MDGAccelerometerData.cpp 0 Remove
        
        File MDGAccelerometerData.h 9 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        File MHDVersionResponse.cpp 0 Remove
        
        File MTreatmentAdjustHDVersionResponse.cpp 0 Remove
        
        File MTreatmentAdjustHDVersionsResponse.cpp 0 Remove
        
        File MTreatmentAdjustHDVersionsResponse.h 4 Remove
        
        File MTreatmentAdjustRequests.h 3 Remove
      - Folder alarm 0
        
        File MAlarmStatusData.cpp 0 Remove
      - Folder data 0
        
        File MHDAccelerometerData.cpp 3 Remove
        
        File MHDAccelerometerData.h 13 Remove
        
        File MHDVersionData.cpp 0 Remove
        
        File MHDVersionData.h 0 Remove
        
        File MTreatmentFlowsData.cpp 0 Remove
        
        File MTreatmentFlowsData.h 0 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder dg 0
      - Folder adjustment 0
        
        File VTreatmentAdjustmentDGVersions.cpp 0 Remove
        
        File VTreatmentAdjustmentDGVersions.h 3 Remove
      - Folder data 0
        
        File VDGAccelerometerData.cpp 0 Remove
        
        File VDGAccelerometerData.h 4 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        File VTreatmentAdjustmentHDVersions.cpp 0 Remove
        
        File VTreatmentAdjustmentHDVersions.h 0 Remove
        
        File VTreatmentAdjustmentSaline.h 0 Remove
        
        File VTreatmentAdjustmentVersions.cpp 0 Remove
        
        File VTreatmentAdjustmentVersions.h 0 Remove
      - Folder data 0
        
        File VHDAccelerometerData.cpp 8 Remove
        
        File VHDAccelerometerData.h 6 Remove
        
        File VHDOperationModeData.h 0 Remove
        
        File VHDVersionData.cpp 0 Remove
    - File vtreatmentbloodflow.h 0 Remove
    - File vtreatmentdialysateflow.h 0 Remove
    - File vview.h 0 Remove
  - File applicationpost.h 0 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
- File denali.pro 15 Remove
- File denali.pro.user 0 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
pmontazemi (deleted user)	Author	4h	36	Reverted change.
Sean Nash	Reviewer - Complete	49m	8	RESOLVED.
plucia (deleted user)	Reviewer - Complete	2h 28m	20	RESOLVED
Behrouz NematiPour	Reviewer - Complete	5h 37m	35	RESOLVED
Total		12h 56m	99

Linked issues
- DEN-4964

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

When this code review started the Doxygenization wasn't done. So assumed that...

When this code review started the Doxygenization wasn't done.
So assumed that this code could be included in master and covered as part of the Doxygenization.
Now that the Doxygenization is done, all the classes shall have the documentation with messaging information.
Please add to all your classes.
For example on how to do please refer to the Model/View classes.
And when doc generated it will also be used for SDD.
it should contain:

\brief
\details
Message information
Message Payload information as each field in a line (see example below)
\sa(see also) which has related classes to this class
Logging info which at least has 3 lines (see example below and follow the HTML syntax for formating in doxygen please.)

An example provided. please look at more examples for your specific case in the code on the master branch.

/*!
 * \brief   The MAdjustSalineResponse class
 * \details The Saline Bolus adjustment response model
 *
 * | MSG | CAN ID | M.Box | Type | Ack | Src | Dest | Description           |
 * |:---:|:------:|:-----:|:----:|:---:|:---:|:----:|:---------------------:|
 * | 20  | 0x020  | 6     | Rsp  | Y   | HD  | UI   | Saline Bolus Response |
 *
 * | Payload  ||
 * |          ||
 * | #1:(U32) | \ref Data::mAccepted |
 * | #2:(U32) | \ref Data::mReason   |
 * | #3:(U32) | \ref Data::mTarget   |
 *
 * \sa Data
 * \sa MAdjustSalineReq : Saline Bolus Request
 * \sa MTreatmentSaline : Saline Bolus Data
 *
 * <h2 class="groupheader">Logging info</h2>
 * |              ||
 * |              ||
 * | typeText     | Event        |
 * | unitText     | HD           |
 * | infoText     | AdjustSaline |
 *
 */

29 Oct 20

Behrouz NematiPour

Resolved

03 Jan 21

pmontazemi (deleted user)

Updated DG/HD accelerometer data class headers, and will apply this header co...

Updated DG/HD accelerometer data class headers, and will apply this header concept for DG/HD version data moving forward.

02 Nov 20

Behrouz NematiPour

Please do the same for the Versions.

16 Dec 20

pmontazemi (deleted user)

Done.

29 Dec 20

Behrouz NematiPour

RESOLVED

03 Jan 21

Click to load diff

/sources/.../adjustment/MHDVersionResponse.cpp Deleted

Click to load diff

/sources/.../adjustment/MTreatmentAdjustHDVersionResponse.cpp Deleted

Click to load diff

/sources/model/hd/data/MHDVersionData.cpp Deleted

Click to load diff

/sources/.../adjustment/VTreatmentAdjustmentDGVersions.cpp Deleted

Click to load diff

/sources/.../adjustment/VTreatmentAdjustmentDGVersions.h Deleted 3 (0)

Click to load diff

/sources/.../adjustment/VTreatmentAdjustmentHDVersions.cpp Deleted

Click to load diff

/sources/.../adjustment/VTreatmentAdjustmentHDVersions.h Deleted

Click to load diff

/sources/view/hd/data/VHDVersionData.cpp Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-4964-1

UI-DEN-4964_UI Messaging Version Accelometer

UI-DEN-4964-1 99

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Log time

UI-DEN-4964_UI Messaging Version Accelometer

UI-DEN-4964-1 99

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Log time