UI-DEN-5282-1 UI-DEN-5282_Ultrafiltration Stop State

closed on 02 Nov 20

Author

Reviewers

UI-DEN-5282_Ultrafiltration Stop State

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 63

application 0
- Folder resources/images 0
  - File Done.png 0 Remove
  - File OffGray.png 0 Remove
  - File alarm.svg 0 Remove
  - File bell-off.svg 0 Remove
  - File bell.svg 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 3 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ModalDialog.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File NotificationBarSmall.qml 0 Remove
        
        File TouchArea.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentBase.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationConfirm.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationEdit.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationPaused.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationStart.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentPressure.qml 0 Remove
        
        File TreatmentSaline.qml 0 Remove
        
        File TreatmentTime.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File ManagerHome.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model/hd 0
    - Folder adjustment 0
      - File MTreatmentAdjustRequests.h 0 Remove
      - File MTreatmentAdjustSalineResponse.cpp 0 Remove
      - File MTreatmentAdjustSalineResponse.h 0 Remove
      - File MTreatmentAdjustUltrafiltrationStateResponse.cpp 0 Remove
      - File MTreatmentAdjustUltrafiltrationStateResponse.h 0 Remove
    - Folder data 0
      - File MTreatmentPressureOcclusionData.h 0 Remove
      - File MTreatmentStatesData.h 0 Remove
  - Folder view/hd 0
    - Folder adjustment 0
      - File VTreatmentAdjustmentResponseBase.cpp 0 Remove
      - File VTreatmentAdjustmentResponseBase.h 0 Remove
      - File VTreatmentAdjustmentSaline.cpp 0 Remove
      - File VTreatmentAdjustmentSaline.h 0 Remove
      - File VTreatmentAdjustmentUltrafiltrationState.cpp 3 Remove
      - File VTreatmentAdjustmentUltrafiltrationState.h 0 Remove
    - Folder data 0
      - File VHDTreatmentStatesData.cpp 0 Remove
      - File VHDTreatmentStatesData.h 0 Remove
      - File VTreatmentPressureOcclusion.h 0 Remove
  - File ApplicationController.h 0 Remove
- Folder unittests 0
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_views.cpp 0 Remove
- File cppcheck.err 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.aff 3 Remove
- File en_US.dic 3 Remove
- File en_US.udic 3 Remove
- File remove-exra-emptylines.sh 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 0 Remove
- Folder simulator 0
  - File SalineBolusSimulator.ui 0 Remove
  - File Simulator.ui 0 Remove
  - File run.py 0 Remove
- Folder tst_HDPressureOcclusionData 0
  - File test.py 0 Remove
- Folder tst_Internals 0
  - File test.py 3 Remove
- Folder tst_TreatmentStatesData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Saline 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Ultrafiltration 0
  - File test.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	2h 54m	6	Objectives: #01 Because of the new standard message (#01)...
plucia (deleted user)	Reviewer - Complete	33m	2	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	12m	10	RESOLVED.
Total		3h 40m	18

Linked issues
- DEN-5282

#permalink

Objectives

Application :
01 - Used new message 65 instead of Generic for the UF state change request which is in the standard response message format by having (accepted,rejection_reason,...)
02 - Used new field, Saline Bolus State, in the saline state change request.
03 - Code improvement.
04 - Used notify function template.
05 - Modified ModalDialog and TreatmentAdjustmentBase to have separate NotificationBar for the Response errors and current state/general info.
06 - Utilize all the Ultrafiltration states to have a more user-friendly UI by enabling/disabling UI components and showing more information on sections and dialogs.
07 - After updating UI with the FW enum for the Saline bolus those enums used as states to have a more user-friendly UI.
08 - For the Treatment duration section used isRunning instead of isPaused since we have isRunning state and all the other states are not running states.
09 - Used UF_Commands FW enum (GuiUFCommands in UI)for UF state change request to be consistent with FW.
10 - Modified Pressure/Occlusion message to have 3 last params out of 5 as U32 which was F32 as requested by FW team.
11 - Centralized all the responses to 1)the Saline state change 2)UF state change and the broadcast 3)Treatment States messages in the Treatment States broadcast by let that view also listen to the other two responses beside those two messages themselves. So whichever received first will be served first and if the reported state is the same PROPERTY by design will not notify UI for the duplicate update.
12 - Updated Profile build to be used as the instrumented UI build built in the workspace_UI to be easily used for local code coverage effort.
13 - Added remove-extra-lines.sh script.
14 - Added QtCreator's Spell Checker pluggin's dictionary files in the root repo folder for all to use and also the user dictionary which will contain project specific words.
testSuites/Simulator:
15 - In Simulator the UI file name changed to Simulator.ui
16 - Added UF 1)Pause 2)Resume 3)Edit/Next 4)Delivered volume
17 - Added Treatment State broadcast as a 1 sec interval broadcast.
18 - update tests with the new UF states and UF,Saline messages.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-5282-1

UI-DEN-5282_Ultrafiltration Stop State

UI-DEN-5282-1 18

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-5282_Ultrafiltration Stop State

UI-DEN-5282-1 18

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time