UI-DEN-5283-1 UI-DEN-5283_Saline Bolus FW Modification

closed on 20 Oct 20

Author

Reviewers

UI-DEN-5283_Saline Bolus FW Modification

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 143

application 0
- Folder sources 0
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ImageClock.qml 0 Remove
        
        File ImageWave.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File ProgressBar.qml 0 Remove
        
        File ProgressBarEx.qml 0 Remove
        
        File ProgressRect.qml 0 Remove
        
        File RangeBar.qml 0 Remove
        
        File RangeMarker.qml 0 Remove
        
        File TickMarks.qml 0 Remove
        
        File UltrafiltrationButton.qml 0 Remove
      - Folder dialogs 0
        
        File AutoHideInfo.qml 0 Remove
        
        File PowerOff.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentDuration.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentPressure.qml 0 Remove
        
        File TreatmentSaline.qml 3 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File ManagerHome.qml 0 Remove
    - File GuiGlobals.h 3 Remove
  - Folder model 0
    - Folder dg/data 0
      - File MDGDrainPumpData.cpp 0 Remove
      - File MDGDrainPumpData.h 0 Remove
      - File MDGHeatersData.cpp 0 Remove
      - File MDGHeatersData.h 0 Remove
      - File MDGLoadCellReadingsData.cpp 0 Remove
      - File MDGLoadCellReadingsData.h 0 Remove
      - File MDGOperationModeData.cpp 0 Remove
      - File MDGOperationModeData.h 0 Remove
      - File MDGPressuresData.cpp 0 Remove
      - File MDGPressuresData.h 0 Remove
      - File MDGROPumpData.cpp 0 Remove
      - File MDGROPumpData.h 0 Remove
      - File MDGReservoirData.cpp 0 Remove
      - File MDGReservoirData.h 0 Remove
      - File MDGTemperaturesData.cpp 0 Remove
      - File MDGTemperaturesData.h 0 Remove
      - File MDGValvesStatesData.cpp 0 Remove
      - File MDGValvesStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustBloodDialysateResponse.cpp 0 Remove
        
        File MTreatmentAdjustBloodDialysateResponse.h 0 Remove
        
        File MTreatmentAdjustDurationResponse.cpp 0 Remove
        
        File MTreatmentAdjustDurationResponse.h 0 Remove
        
        File MTreatmentAdjustRequests.h 0 Remove
        
        File MTreatmentAdjustUltrafiltrationConfirmResponse.cpp 0 Remove
        
        File MTreatmentAdjustUltrafiltrationConfirmResponse.h 0 Remove
        
        File MTreatmentAdjustUltrafiltrationEditResponse.cpp 0 Remove
        
        File MTreatmentAdjustUltrafiltrationEditResponse.h 0 Remove
        
        File MTreatmentAdjustUltrafiltrationStateResponse.cpp 0 Remove
        
        File MTreatmentAdjustUltrafiltrationStateResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmCleared.cpp 0 Remove
        
        File MAlarmCleared.h 0 Remove
        
        File MAlarmStatusData.cpp 0 Remove
        
        File MAlarmStatusData.h 0 Remove
        
        File MAlarmTriggered.cpp 0 Remove
        
        File MAlarmTriggered.h 0 Remove
      - Folder data 0
        
        File MHDOperationModeData.cpp 0 Remove
        
        File MHDOperationModeData.h 0 Remove
        
        File MTreatmentFlowsData.cpp 0 Remove
        
        File MTreatmentFlowsData.h 0 Remove
        
        File MTreatmentOutletFlowData.cpp 0 Remove
        
        File MTreatmentOutletFlowData.h 0 Remove
        
        File MTreatmentPressureOcclusionData.cpp 0 Remove
        
        File MTreatmentPressureOcclusionData.h 0 Remove
        
        File MTreatmentRangesData.cpp 0 Remove
        
        File MTreatmentRangesData.h 0 Remove
        
        File MTreatmentStatesData.cpp 0 Remove
        
        File MTreatmentStatesData.h 0 Remove
        
        File MTreatmentTimeData.cpp 0 Remove
        
        File MTreatmentTimeData.h 0 Remove
    - File MAbstract.cpp 0 Remove
    - File MAbstract.h 0 Remove
    - File MDGDebugText.cpp 0 Remove
    - File MDGDebugText.h 0 Remove
    - File MHDDebugText.cpp 0 Remove
    - File MHDDebugText.h 0 Remove
    - File MModel.h 0 Remove
    - File MPowerOff.cpp 0 Remove
    - File MPowerOff.h 0 Remove
  - Folder storage 0
    - File DriveWatcher.cpp 0 Remove
    - File DriveWatcher.h 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - File VDGDrainPumpData.cpp 0 Remove
      - File VDGDrainPumpData.h 0 Remove
      - File VDGHeatersData.cpp 0 Remove
      - File VDGHeatersData.h 0 Remove
      - File VDGLoadCellReadingsData.cpp 0 Remove
      - File VDGLoadCellReadingsData.h 0 Remove
      - File VDGOperationModeData.cpp 0 Remove
      - File VDGOperationModeData.h 0 Remove
      - File VDGPressuresData.cpp 0 Remove
      - File VDGPressuresData.h 0 Remove
      - File VDGROPumpData.cpp 0 Remove
      - File VDGROPumpData.h 0 Remove
      - File VDGReservoirData.cpp 0 Remove
      - File VDGReservoirData.h 0 Remove
      - File VDGTemperaturesData.cpp 0 Remove
      - File VDGTemperaturesData.h 0 Remove
      - File VDGValvesStatesData.cpp 0 Remove
      - File VDGValvesStatesData.h 0 Remove
    - Folder hd/adjustment 0
      - File VTreatmentAdjustmentResponseBase.cpp 0 Remove
      - File VTreatmentAdjustmentSaline.cpp 0 Remove
      - File VTreatmentAdjustmentUltrafiltrationState.cpp 0 Remove
    - File VEventSpy.cpp 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File main.cpp 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 0 Remove
- Folder simulator 0
  - File SalineBolusSimulator.ui 0 Remove
  - File run.py 0 Remove
- Folder tst_AlarmCleared 0
  - File test.py 0 Remove
- Folder tst_AlarmStatusData 0
  - File test.py 0 Remove
- Folder tst_AlarmTriggered 0
  - File test.py 0 Remove
- Folder tst_Alarm_Colors 0
  - File test.py 0 Remove
- Folder tst_CANBusFaultCount 0
  - File test.py 0 Remove
- Folder tst_DGDrainPumpData 0
  - File test.py 0 Remove
- Folder tst_DGHeatersData 0
  - File test.py 0 Remove
- Folder tst_DGLoadCellReadingsData 0
  - File test.py 0 Remove
- Folder tst_DGOperationMode 0
  - File test.py 0 Remove
- Folder tst_DGPressureData 0
  - File test.py 0 Remove
- Folder tst_DGROPumpData 0
  - File test.py 0 Remove
- Folder tst_DGReservoirData 0
  - File test.py 0 Remove
- Folder tst_DGTemperaturesData 0
  - File test.py 0 Remove
- Folder tst_DGValvesStatesData 0
  - File test.py 0 Remove
- Folder tst_DebugText 0
  - File test.py 0 Remove
- Folder tst_HDBloodFlowData 0
  - File test.py 0 Remove
- Folder tst_HDInletFlowData 0
  - File test.py 0 Remove
- Folder tst_HDOperationModeData 0
  - File test.py 0 Remove
- Folder tst_HDOutletFlowData 0
  - File test.py 0 Remove
- Folder tst_HDPressureOcclusionData 0
  - File test.py 0 Remove
- Folder tst_HomeScreen 0
  - File test.py 0 Remove
- Folder tst_ServiceShutdown 0
  - File test.py 0 Remove
- Folder tst_TreatmentScreen 0
  - File test.py 0 Remove
- Folder tst_TreatmentStatesData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_BloodDialysate 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Duration 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Saline 0
  - File test.py 3 Remove
- Folder tst_Treatment_Adjustment_Ultrafiltration 0
  - File test.py 0 Remove
- Folder tst_Treatment_BloodDialysateFlowRate 0
  - File test.py 0 Remove
- Folder tst_Treatment_ParametersRange 0
  - File test.py 0 Remove
- Folder tst_Treatment_PressureOcclusion 0
  - File test.py 0 Remove
- Folder tst_Treatment_Section_BloodDialysate 0
  - File test.py 0 Remove
- Folder tst_Treatment_Time 0
  - File test.py 0 Remove
- Folder tst_Treatment_Ultrafiltration 0
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	45m	3	This is not UI Application Software naming conventions. T...
plucia (deleted user)	Reviewer - Complete	28m	6	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	18m
Total		1h 31m	9

Linked issues
- DEN-5283
- DEN-5284

#permalink

Objectives

Application repo :
------------------------
Story related fixes:

Used FW enum for Saline Bolus in Common repo
txPaused modified the way FW understands and transmits.

Extra fixes:

Changed the Ultrafiltration ref/meas vol to 3 decimals.
Application version wasn't correctly shown
Added a #define for the mouse event spy since on target it's not usually happening and is not useful neither on a target nor on the desktop for now.
Fixed the author typo
Cherry Picked the fix for the version from the In-Line branch.

testsuites repo:
------------------------
Story fixes:

Unit testing and integration testing for the sub-task DEN-5284: implementation
modified the HDOutletFlow test for the 3 decimals.

Extra fixes:

Modified the Simulator to be Object-Oriented designed.
Removed backward compatibility with the old squish codes out of Dialin.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-5283-1

UI-DEN-5283_Saline Bolus FW Modification

UI-DEN-5283-1 9

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-5283_Saline Bolus FW Modification

UI-DEN-5283-1 9

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time