UI-DEN-5777_UI Dev Convert Logging From Hours to %

Activity

UI-DEN-5777-1 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 24m 4 fixed.
    plucia  (deleted user)
    Reviewer completed
    Reviewer - Complete 18m    
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 22m 8 RESOLVED.
    Total   1h 5m 12  
    #permalink

    Objectives

    Applicarion:

    • Added a signal named didSDCardSpaceTooLow in the DriveWatcher which will be triggered when the free storage space available on the SD-CARD is less than 10%. (No action on UI happens currently)
    • Added a flag in DriveWatcher to stop emitting the Logger while it is cleaning the Logs [[ IMPORTANT : is is handled by signal/slots for thread synchronization and safety ]].
    • Added a function to find the total size of the file in a path.
    • Added find function to find files with a list of filter in a path.
    • Added an overloaded version of find to help find the files in a path which are exceeding the storage limit from the oldest files.
    • Added error check in the read overloaded which works with Json.
    • Re-implemented the FileHandler::removeLogs to clean up the logs by % instead of date.
    • Removed unused global log paths from StorageGlobal.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /sources/gui/GuiController.cpp Changed
    /sources/gui/GuiController.h Changed
    /sources/gui/GuiView.cpp Changed
    /sources/gui/GuiView.h Changed
    /sources/storage/DriveWatcher.cpp Changed
    /sources/storage/DriveWatcher.h Changed
    /sources/storage/FileHandler.cpp Changed 9
    /sources/storage/FileHandler.h Changed
    /sources/storage/Logger.cpp Changed
    /sources/storage/Logger.h Changed 3
    /sources/storage/StorageGlobals.cpp Changed
    /sources/view/VTreatmentCreate.cpp Changed
    /sources/ApplicationController.cpp Changed
    /sources/ApplicationController.h Changed
    /unittests/tst_views.cpp Changed
    /denali.pro.user Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time