DG-DEN-12847

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

10-20 seems like a better number, but my sample size is small so I did not change it.

10-20 seems like a better number, but my sample size is small so I did not change it.

Updated

Updated

Updated

Updated

Are we sticking with this threshold?

Are we sticking with this threshold?

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

Make this assignment explicitly BOOL (i.e. TRUE or FALSE), not implied bool.

Use our boolean #define (FALSE) instead of built-in (false).

Use our boolean #define (FALSE) instead of built-in (false).

Remove blank line.

Remove blank line.

Coding standard wants just one return statement in a function. Set a local boolean in if/else and return that.

Coding standard wants just one return statement in a function. Set a local boolean in if/else and return that.

DG-DEN-12847_SW Dev Sprint 71 Darren
DG-DEN-12847_SW Dev Sprint 71 Darren