DG-DEN-13946

DG-DEN-13946

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,308
Last Commit: 05 Jan
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 18 Jan 2023
2:05 pm

Dara Navaei

2:04 pm

Dara Navaei , Sean Nash and dcox  (deleted user)

10:43 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Tuesday 17 Jan 2023
3:33 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:43 pm

wbracken  (deleted user)

Updated comment

Updated comment

12:03 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:00 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Friday 13 Jan 2023
11:39 am

wbracken  (deleted user)

Corrected.

Corrected.

11:38 am

wbracken  (deleted user)

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

11:31 am

wbracken  (deleted user)

Only used if the load cell is out of range.

Only used if the load cell is out of range.

10:41 am

dcox  (deleted user)

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

10:38 am

dcox  (deleted user)

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

10:35 am

dcox  (deleted user)

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

10:34 am

dcox  (deleted user)

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

Tuesday 10 Jan 2023
8:30 am

Sean Nash

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

8:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 09 Jan 2023
11:37 am

wbracken  (deleted user)

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

11:07 am

wbracken  (deleted user)

Removed.

Removed.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

Friday 06 Jan 2023
4:02 pm

Sean Nash

Why change this to U08?

Why change this to U08?

Wednesday 04 Jan 2023
3:00 pm

Dara Navaei

DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm