DG-DEN-13989

DG-DEN-13989

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,308
Last Commit: 05 Jan
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 16 Jun 2023
1:15 pm

jtaylor  (deleted user)

Friday 02 Jun 2023
5:13 pm

wbracken  (deleted user) and Michael Garthwaite

Thursday 01 Jun 2023
1:11 pm

jtaylor  (deleted user)

12:01 pm

Dara Navaei

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
Friday 26 May 2023
8:01 pm

Dara Navaei

DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_FW Concentrate Pump Cp1 Speed Error Observed
3:20 pm

jtaylor  (deleted user)

3:19 pm

jtaylor  (deleted user)

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.

Wednesday 17 May 2023
5:11 pm

wbracken  (deleted user)

Tuesday 16 May 2023
4:36 pm

Michael Garthwaite

Tuesday 25 Apr 2023
8:47 am

jtaylor  (deleted user)

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alar...

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alarm. If problems continue, we should consider increasing the trigger interval, decreasing the clear interval, and/or resetting the alarm when the target is set to zero (or taking a large step).

Monday 24 Apr 2023
5:11 pm

Sean Nash and dcox  (deleted user)

5:11 pm

Sean Nash

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the pe...

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the persistence is being cleared all the time while mixing, essentially rendering the alarm disabled. I don't think we should reset here.

3:33 pm

jtaylor  (deleted user)

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

3:29 pm

jtaylor  (deleted user)

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on i...

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on it's way to being triggered.

3:19 pm

Dara Navaei

What does MAG stand for?

What does MAG stand for?

3:17 pm

Dara Navaei

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

2:08 pm

Dara Navaei

Why are we resetting the persistent alarms here?

Why are we resetting the persistent alarms here?

10:48 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 19 Apr 2023
12:15 pm

jtaylor  (deleted user)

Corrected.

Corrected.

Tuesday 18 Apr 2023
2:26 pm

wbracken  (deleted user)

Align "="

Align "="

Wednesday 12 Apr 2023
5:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:21 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:41 pm

jtaylor  (deleted user)

Thank you, done.

Thank you, done.

12:41 pm

jtaylor  (deleted user)

Thank you, done.

Thank you, done.

Tuesday 11 Apr 2023
2:15 pm

wbracken  (deleted user)

0.0F, maybe a #define?

0.0F, maybe a #define?

2:14 pm

wbracken  (deleted user)

0.0F

0.0F

12:01 pm

Dara Navaei

DG-DEN-13989_Concentrate Pump Cp1 Speed Error Observed
DG-DEN-13989_Concentrate Pump Cp1 Speed Error Observed