DG-DEN-14646

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14646_Fpga Alarm Properties And Timing 3
DG-DEN-14646_Fpga Alarm Properties And Timing 3
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Corrected

Corrected

Corrected

Corrected

Corrected

Corrected

Does TODO need to be resolved?

Does TODO need to be resolved?

Extra space before the last paren.

Extra space before the last paren.

Missing space.

Missing space.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Corrected

Corrected

Can we rename variable to reflect it is a timer counter at least?

Can we rename variable to reflect it is a timer counter at least?

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, and #define has "COUNT" in its name which was my point.

Yes, and #define has "COUNT" in its name which was my point.

Corrected

Corrected

Alarm is based on a counter. The #define corresponds to a 100ms time.

Alarm is based on a counter. The #define corresponds to a 100ms time.

Corrected

Corrected

Added DEBUG WARNING

Added DEBUG WARNING

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.