DG-DEN-14706

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Too many () after &&?

Too many () after &&?

Remove extra blank line.

Remove extra blank line.

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Suggest aligning comments in the block above

Suggest aligning comments in the block above

Removed #define. Thanks!

Removed #define. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I don't see where this #define is ever used. Remove if not needed.

I don't see where this #define is ever used. Remove if not needed.

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked