DG-DEN-15014

DG-DEN-15014

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,303
Last Commit: 20 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 29 Mar 2023
8:37 am

Dara Navaei

8:08 am

Sean Nash

Tuesday 28 Mar 2023
5:19 pm

Dara Navaei

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Dara Navaei

Done

Done

5:03 pm

Sean Nash

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

5:00 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

Dara Navaei

Check the diff of the last two commits.

Check the diff of the last two commits.

4:58 pm

Sean Nash

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

4:58 pm

Dara Navaei

Done

Done

4:57 pm

Sean Nash

Remove TODO?

Remove TODO?

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:47 pm

Dara Navaei

Done

Done

4:43 pm

Dara Navaei

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.

4:43 pm

Dara Navaei

Updated the code.

Updated the code.

4:42 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:17 pm

Dara Navaei

Done

Done

4:15 pm

Dara Navaei

Done

Done

4:13 pm

Dara Navaei

Done

Done

4:10 pm

Sean Nash

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.

4:08 pm

Sean Nash

Needs param so caller can set it to FALSE too?

Needs param so caller can set it to FALSE too?

4:07 pm

Sean Nash

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).