DIALIN-DEN-11980

DIALIN-DEN-11980_SW Dev Sprint 64
DIALIN-DEN-11980_SW Dev Sprint 64
RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

Fixed. Thanks!

Fixed. Thanks!

Please update the BloodFlow and DialysateFlow in the hd_simulator as well.

Please update the BloodFlow and DialysateFlow in the hd_simulator as well.

Just to keep the main reference link: https://docs.python.org/3/library/struct.html#format-characters
Totally agree, I just wanted to make sure we've planned to do that. RESOLVED.

Totally agree,
I just wanted to make sure we've planned to do that.
RESOLVED.

that'll be done in another sprint as ALL methods need to convert to that.

that'll be done in another sprint as ALL methods need to convert to that.

I think soon we need to replace these error-prone indexing data extraction with the new conversion functions in the utility module. As an example take a look at ui/hd_simulator.py@1926: @publis...

I think soon we need to replace these error-prone indexing data extraction with the new conversion functions in the utility module.
As an example take a look at ui/hd_simulator.py@1926:

    @publish(["ui_version"])
    def _handler_ui_version(self, message) -> None:
        """
        Handles the ui version response
        @param message: The ui version response message
        @return: None
        """
        payload = message['message']
        index = DenaliMessage.PAYLOAD_START_INDEX
        major, index = bytearray_to_byte(payload, index, False)
        minor, index = bytearray_to_byte(payload, index, False)
        micro, index = bytearray_to_byte(payload, index, False)
        build, index = bytearray_to_short(payload, index, False)
        compt, index = bytearray_to_integer(payload, index, False)

        self.ui_version = f"v{major}.{minor}.{micro}.{build}.{compt}"
        self.logger.debug(f"UI VERSION: {self.ui_version}")

        if self.console_out:
            print("Version:", self.ui_version)
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

I'm indifferent to the idea. Since the current values are more of a "real time" feature and don't need a broadcast message to update their values. The other properties need a reset for this reason....

I'm indifferent to the idea. Since the current values are more of a "real time" feature and don't need a broadcast message to update their values. The other properties need a reset for this reason. What do you think?

struct.py lists the args to unpack as such: "The remaining chars indicate types of args and must match exactly; these can be preceded by a decimal repeat count: x: pad byte (no data); c:char; b:si...

struct.py lists the args to unpack as such:

"The remaining chars indicate types of args and must match exactly;
these can be preceded by a decimal repeat count:
x: pad byte (no data);
c:char;
b:signed byte;
B:unsigned byte;
?: _Bool (requires C99; if not available, char is used instead)
h:short;
H:unsigned short;
i:int;
I:unsigned int; (Capital i)
l:long;
L:unsigned long;
f:float;
d:double;
e:half-float."

Rotor_count is sent from the HD as an unsigned int (U32).

Should the new current treatment params above be reset in this function?

Should the new current treatment params above be reset in this function?

This looks wrong too.

This looks wrong too.

Brief looks wrong.

Brief looks wrong.

Why is I capitalized?

Why is I capitalized?

DIALIN-DEN-11980_SW Dev Sprint 64
DIALIN-DEN-11980_SW Dev Sprint 64