DIALIN-DEN-11980

DIALIN-DEN-11980

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 19 Oct 2023
1:09 pm

Dara Navaei

1:08 pm

Dara Navaei

DIALIN-DEN-11980_SW Dev Sprint 64
DIALIN-DEN-11980_SW Dev Sprint 64
1:05 pm

Dara Navaei

1:04 pm

Dara Navaei

RESOLVED

RESOLVED

Tuesday 22 Feb 2022
1:01 pm

Michael Garthwaite

11:40 am

Behrouz NematiPour

11:40 am

Behrouz NematiPour

RESOLVED.

RESOLVED.

Thursday 17 Feb 2022
11:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:43 am

Sean Nash

10:50 am

Behrouz NematiPour

Please update the BloodFlow and DialysateFlow in the hd_simulator as well.

Please update the BloodFlow and DialysateFlow in the hd_simulator as well.

10:27 am

Behrouz NematiPour

Just to keep the main reference link: https://docs.python.org/3/library/struct.html#format-characters

Just to keep the main reference link:
https://docs.python.org/3/library/struct.html#format-characters

10:20 am

Behrouz NematiPour

Totally agree, I just wanted to make sure we've planned to do that. RESOLVED.

Totally agree,
I just wanted to make sure we've planned to do that.
RESOLVED.

10:07 am

Michael Garthwaite

that'll be done in another sprint as ALL methods need to convert to that.

that'll be done in another sprint as ALL methods need to convert to that.

10:02 am

Behrouz NematiPour

I think soon we need to replace these error-prone indexing data extraction with the new conversion functions in the utility module. As an example take a look at ui/hd_simulator.py@1926: @publis...

I think soon we need to replace these error-prone indexing data extraction with the new conversion functions in the utility module.
As an example take a look at ui/hd_simulator.py@1926:

    @publish(["ui_version"])
    def _handler_ui_version(self, message) -> None:
        """
        Handles the ui version response
        @param message: The ui version response message
        @return: None
        """
        payload = message['message']
        index = DenaliMessage.PAYLOAD_START_INDEX
        major, index = bytearray_to_byte(payload, index, False)
        minor, index = bytearray_to_byte(payload, index, False)
        micro, index = bytearray_to_byte(payload, index, False)
        build, index = bytearray_to_short(payload, index, False)
        compt, index = bytearray_to_integer(payload, index, False)

        self.ui_version = f"v{major}.{minor}.{micro}.{build}.{compt}"
        self.logger.debug(f"UI VERSION: {self.ui_version}")

        if self.console_out:
            print("Version:", self.ui_version)
Wednesday 16 Feb 2022
10:29 am

Sean Nash

RESOLVED.

RESOLVED.

10:29 am

Sean Nash

RESOLVED.

RESOLVED.

10:28 am

Sean Nash

RESOLVED.

RESOLVED.

10:28 am

Sean Nash

RESOLVED.

RESOLVED.

10:12 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:12 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:53 am

Michael Garthwaite

I'm indifferent to the idea. Since the current values are more of a "real time" feature and don't need a broadcast message to update their values. The other properties need a reset for this reason....

I'm indifferent to the idea. Since the current values are more of a "real time" feature and don't need a broadcast message to update their values. The other properties need a reset for this reason. What do you think?

9:46 am

Michael Garthwaite

struct.py lists the args to unpack as such: "The remaining chars indicate types of args and must match exactly; these can be preceded by a decimal repeat count: x: pad byte (no data); c:char; b:si...

struct.py lists the args to unpack as such:

"The remaining chars indicate types of args and must match exactly;
these can be preceded by a decimal repeat count:
x: pad byte (no data);
c:char;
b:signed byte;
B:unsigned byte;
?: _Bool (requires C99; if not available, char is used instead)
h:short;
H:unsigned short;
i:int;
I:unsigned int; (Capital i)
l:long;
L:unsigned long;
f:float;
d:double;
e:half-float."

Rotor_count is sent from the HD as an unsigned int (U32).

9:34 am

Sean Nash

Should the new current treatment params above be reset in this function?

Should the new current treatment params above be reset in this function?

9:31 am

Sean Nash

This looks wrong too.

This looks wrong too.

9:31 am

Sean Nash

Brief looks wrong.

Brief looks wrong.

9:28 am

Sean Nash

Why is I capitalized?

Why is I capitalized?

9:00 am

Michael Garthwaite

DIALIN-DEN-11980_SW Dev Sprint 64
DIALIN-DEN-11980_SW Dev Sprint 64