DIALIN-DEN-12358

DIALIN-DEN-12358

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 19 Oct 2023
1:02 pm

Dara Navaei

1:02 pm

Dara Navaei

RESOLVED

RESOLVED

1:00 pm

Dara Navaei

DIALIN-DEN-12358_SW Dev Sprint 67 MG
DIALIN-DEN-12358_SW Dev Sprint 67 MG
Tuesday 19 Jul 2022
10:35 am

Michael Garthwaite

Tuesday 12 Jul 2022
12:08 pm

Behrouz NematiPour

Please take care of it as soon as you found time. It's quite a bit of time since we talked about and It's a month since I created a case for that. RESOLVED for now.

Please take care of it as soon as you found time.
It's quite a bit of time since we talked about and It's a month since I created a case for that.

RESOLVED for now.

9:58 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:51 am

Michael Garthwaite

In ticket http://dvm-linux02:8080/browse/DIAL-171

In ticket http://dvm-linux02:8080/browse/DIAL-171

Tuesday 28 Jun 2022
3:53 pm

Behrouz NematiPour

RESOLVED for now.

RESOLVED for now.

9:05 am

Michael Garthwaite

QoL feature = Quality of Life feature. It is a feature for users (V&V and sys) that allows them to exercise the API and generate tests faster. Breaking this current design would cause some major r...

QoL feature = Quality of Life feature.

It is a feature for users (V&V and sys) that allows them to exercise the API and generate tests faster. Breaking this current design would cause some major refactoring for them as they expect the HD and DG classes to have the sub modules loaded.

We can look into the technical performance in http://dvm-linux02:8080/browse/DIAL-172

Tuesday 14 Jun 2022
9:49 am

Sean Nash

Agree with Behrouz's initial proposed change above.

Agree with Behrouz's initial proposed change above.

9:35 am

Sean Nash

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans. If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly. I think the c...

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans.
If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly.
I think the current way this assignment is coded is making no assumptions and explicitly converting integer to boolean which is ok with me.

Thursday 09 Jun 2022
9:02 am

Behrouz NematiPour

I not I understand the answer and how that related to my question. I think what I am trying to say is: *Why do we create an object that we have no use for it, yet. *Why create an object for every...

I not I understand the answer and how that related to my question.
I think what I am trying to say is:

  • Why do we create an object that we have no use for it, yet.
  • Why create an object for every class before even being used.
  • Or Why it is not being created when it is needed and where it is going to be used.


And could you please help understand what is "QoL feature"?

8:56 am

Behrouz NematiPour

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary. alarm_cto[0] == 1 it...

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary.

alarm_cto[0] == 1

it is double the unnecessary work and confusing.

8:52 am

Behrouz NematiPour

We should improve the Dialin coding someday! RESOLVED

We should improve the Dialin coding someday!
RESOLVED

8:51 am

Behrouz NematiPour

Yes, Sean Nash, a Jira task, I meant. RESOLVED.

Yes, Sean Nash, a Jira task, I meant.
RESOLVED.

Wednesday 08 Jun 2022
11:19 am

Michael Garthwaite

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_...

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_class and it ends up interfering with their data collection.

Wednesday 25 May 2022
10:16 am

Behrouz NematiPour and Sean Nash

Wednesday 11 May 2022
8:49 am

Sean Nash

I'm ok with this either way. Ternary should not be viewed as confusing, but agree it is unnecessary.

I'm ok with this either way. Ternary should not be viewed as confusing, but agree it is unnecessary.

8:47 am

Sean Nash

Mike, can you please look at updating these (and perhaps many others throughout Dialin)?

Mike, can you please look at updating these (and perhaps many others throughout Dialin)?

8:46 am

Sean Nash

I'm open to suggestions. It's been this way forever and has been working fine, so I'm also good leaving this as is.

I'm open to suggestions. It's been this way forever and has been working fine, so I'm also good leaving this as is.

8:45 am

Sean Nash

By "case", you mean a Jira bug? Sure, we can do that.

By "case", you mean a Jira bug? Sure, we can do that.

Thursday 07 Apr 2022
2:25 pm

Behrouz NematiPour

I don't see any reference/use to the created object. Why do we need to create all the objects while we don't even use them? This approach creates a lot of dependencies and also makes Dialin a very ...

I don't see any reference/use to the created object.
Why do we need to create all the objects while we don't even use them?
This approach creates a lot of dependencies and also makes Dialin a very heavy API to load.

2:17 pm

Behrouz NematiPour

Unnecessary/confusing use of ternary-if. please change to: self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1

Unnecessary/confusing use of ternary-if.
please change to:

self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1
2:11 pm

Behrouz NematiPour

It is big data to be reserved and filled with just default values, There should be a better way.

It is big data to be reserved and filled with just default values, There should be a better way.

2:10 pm

Behrouz NematiPour

Please use conversions.py

Please use conversions.py

1:32 pm

Behrouz NematiPour

Sean Nash, Dara Navaei, Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build. It should be d...

Sean Nash, Dara Navaei,
Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build.
It should be done when the actual code is changed in the common repo, not the dialin.
I am going to update UI now but the comment is for later.

Tuesday 29 Mar 2022
4:14 pm

Michael Garthwaite

DIALIN-DEN-12358_SW Dev Sprint 67 MG
DIALIN-DEN-12358_SW Dev Sprint 67 MG