DIALIN-DEN-7860

DIALIN-DEN-7860

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 27 May 2021
9:57 am

pmontazemi  (deleted user)

9:56 am

Sean Nash

Monday 24 May 2021
1:11 pm

Sean Nash

RESOLVED.

RESOLVED.

9:29 am

plucia  (deleted user)

9:02 am

pmontazemi  (deleted user)

Removed.

Removed.

Friday 21 May 2021
4:25 pm

Sean Nash

Is this print meant to be permanent? Or is it debug code?

Is this print meant to be permanent? Or is it debug code?

6:56 am

plucia  (deleted user)

RESOLVED

RESOLVED

Thursday 20 May 2021
11:21 am

pmontazemi  (deleted user)

Addressed. Sean Nash [~plucia] Please check and resolve.

Addressed. Sean Nash [~plucia] Please check and resolve.

10:35 am

Sean Nash

RESOLVED.

RESOLVED.

Wednesday 19 May 2021
5:04 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:52 pm

Sean Nash

RESOLVED.

RESOLVED.

1:52 pm

Sean Nash

RESOLVED.

RESOLVED.

1:51 pm

Sean Nash

I think older classes may not have get functions for everything, but Sarina and others prefer get functions to accessing properties directly so we're trying to create get functions for every collec...

I think older classes may not have get functions for everything, but Sarina and others prefer get functions to accessing properties directly so we're trying to create get functions for every collected data.

1:49 pm

Sean Nash

Actually they should be in multiples of 50ms (general task). I mistakenly had a few functions written with 10ms (priority task) but that is not correct. I don't think it would cause an error, but n...

Actually they should be in multiples of 50ms (general task). I mistakenly had a few functions written with 10ms (priority task) but that is not correct. I don't think it would cause an error, but non-multiple intervals will be floored to nearest lower multiple of 50 ms by the f/w I suspect.

11:06 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:05 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:05 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:02 am

plucia  (deleted user)

I wasn't aware the ms needed to be in multiples of 10ms. I've created a case DIAL-115 to add constraint enforcement across dialin. For now, I think new code should incorporate some form of constrai...

I wasn't aware the ms needed to be in multiples of 10ms. I've created a case DIAL-115 to add constraint enforcement across dialin.
For now, I think new code should incorporate some form of constraint enforcement. So if you could just apply it here in DIAL-115 I will address this in other parts of dialin.
I think the docstring describing the constraint is useful and should be kept if it's already there even if we add code to check the constraint as well.

10:38 am

pmontazemi  (deleted user)

Blood leak currently outputs the states of the state machine to the console as it changes. If we want to get the state, we will need to implement it here and for Blood Leak as well. How are the oth...

Blood leak currently outputs the states of the state machine to the console as it changes. If we want to get the state, we will need to implement it here and for Blood Leak as well. How are the other Dialin API libraries handling it? We need to be consistent across here.

10:36 am

pmontazemi  (deleted user)

None of the functions we have check for any of these conditions. If we want to implement this in the code, we will need to remove this comment from all *.py Dialin API files and implement the check...

None of the functions we have check for any of these conditions. If we want to implement this in the code, we will need to remove this comment from all *.py Dialin API files and implement the checks in all *.py Dialin API files. Please let me know how you would like to proceed.

10:31 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:31 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:09 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:08 am

plucia  (deleted user)

Instead of cmd_air_bubbles_data_broadcast_interval_override(self, ms, reset=NO_RESET): you need cmd_air_bubbles_data_broadcast_interval_override(self, ms: int, reset: int = NO_RESET) -> int: ...

Instead of 

 cmd_air_bubbles_data_broadcast_interval_override(self, ms, reset=NO_RESET):

you need

 cmd_air_bubbles_data_broadcast_interval_override(self, ms: int, reset: int = NO_RESET) -> int:

It is necessary to have typing information in commands so the service app can call them correctly
Also, putting the typing information in the docstring is good, but it's better to have it in the function so that it can be dynamically interpreted when the code is inspected

10:02 am

plucia  (deleted user)

This should be checked in the function

This should be checked in the function

10:02 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:01 am

pmontazemi  (deleted user)

Addressed.

Addressed.

9:52 am

pmontazemi  (deleted user)

Are you referring to comment section below? There I state @param ms: integer (in ms) etc. If you are referring to something else, please provide an example of what you are expecting to see as I do ...

Are you referring to comment section below? There I state @param ms: integer (in ms) etc. If you are referring to something else, please provide an example of what you are expecting to see as I do not understand the comment.

Tuesday 18 May 2021
4:11 pm

plucia  (deleted user)

Missing typing information for parameters and return type

Missing typing information for parameters and return type

4:11 pm

plucia  (deleted user)

Missing typing information for parameters and return type

Missing typing information for parameters and return type