HD-DEN-12609

HD-DEN-12609

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 26 Aug 2022
3:02 pm

Michael Garthwaite

2:59 pm

Dara Navaei and Sean Nash

2:14 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

Darren Cox

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:19 am

Michael Garthwaite

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

Thursday 25 Aug 2022
4:40 pm

Sean Nash

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

4:37 pm

Sean Nash

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

4:35 pm

Sean Nash

Remove all of these new blank lines.

Remove all of these new blank lines.

Wednesday 24 Aug 2022
4:47 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:47 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:47 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:59 pm

Sean Nash

Can we get to this if condition before we've even set bloodPumpOcclusionAfterCartridgeInstall ? And, if so, is that a problem?

Can we get to this if condition before we've even set bloodPumpOcclusionAfterCartridgeInstall ? And, if so, is that a problem?

3:31 pm

Darren Cox

Extra space before comment.

Extra space before comment.

3:30 pm

Darren Cox

Blank lines before and after if.

Blank lines before and after if.

3:29 pm

Darren Cox

Comment says PreTreat, If checks for Treatment. Also space needed after if.

Comment says PreTreat, If checks for Treatment. Also space needed after if.

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Michael Garthwaite

Can you clarify what case you're thinking of?

Can you clarify what case you're thinking of?

Tuesday 14 Jun 2022
9:27 am

Sean Nash

Should probably log ms - so need to multiply by task interval.

Should probably log ms - so need to multiply by task interval.