HD-DEN-1312

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add blank line at eof.

Add blank line at eof.

Remove blank line.

Remove blank line.

Add space.

Add space.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I only made these volatile to see if it helped with CAN issue (it did not). I'll likely change them back to remove the volatile property. We only need volatile if we access a variable multiple time...

I only made these volatile to see if it helped with CAN issue (it did not). I'll likely change them back to remove the volatile property. We only need volatile if we access a variable multiple times within a function and expect other threads may have changed the variable's value between accesses (as compiler may optimize the function to only access it once if not volatile). Other means of thread protection should prevent other threads from accessing a given side of a buffer at the same time.

Is this commBuffers not called from different threads? if so, don't we need it to set it to volatile too?

Is this commBuffers not called from different threads? if so, don't we need it to set it to volatile too?

Needed for re-purposing a SPI4 pin for GPIO (used by dialysate outlet pump).

Needed for re-purposing a SPI4 pin for GPIO (used by dialysate outlet pump).

Not new. Bitbucket shows sys_core.asm was always in project.

Not new. Bitbucket shows sys_core.asm was always in project.

What added functionality triggered the creation of the assembly and command files?

What added functionality triggered the creation of the assembly and command files?

Why are we using both mibSPI and SPI?

Why are we using both mibSPI and SPI?

Add extra space to all for legibility

Add extra space to all for legibility

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control