HD-DEN-14980

HD-DEN-14980

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 2
Total Commits: 3,310
Last Commit: 05 Feb
Commits this week: 2

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 25 Apr 2023
9:05 am

jtaylor  (deleted user)

Monday 24 Apr 2023
6:25 pm

wbracken  (deleted user) and Sean Nash

5:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:20 pm

jtaylor  (deleted user)

Done.

Done.

1:55 pm

Sean Nash

Was expecting you to move if, not else. Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

12:25 pm

jtaylor  (deleted user)

Thank you - corrected.

Thank you - corrected.

9:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Sean Nash

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

Friday 21 Apr 2023
3:03 pm

jtaylor  (deleted user)

Alarm checks re-ordered.

Alarm checks re-ordered.

3:01 pm

jtaylor  (deleted user)

Comment corrected.

Comment corrected.

1:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

Sean Nash

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

1:31 pm

Sean Nash

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

12:15 pm

dcox  (deleted user)

12:15 pm

jtaylor  (deleted user)

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

11:42 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:18 am

jtaylor  (deleted user)

Done.

Done.

Thursday 20 Apr 2023
11:25 am

wbracken  (deleted user)

Add alarmStatus to header

Add alarmStatus to header

Wednesday 19 Apr 2023
10:01 am

Dara Navaei

HD-DEN-14980_Unable TO Resume After HD Unit Plugged Back IN Pre Treatment After Priming
HD-DEN-14980_Unable TO Resume After HD Unit Plugged Back IN Pre Treatment After Priming