HD-DEN-15306

HD-DEN-15306

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 14 Jun 2023
12:59 pm

Dara Navaei

12:57 pm

Sean Nash

Tuesday 13 Jun 2023
11:48 am

wbracken  (deleted user)

Friday 02 Jun 2023
6:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:54 pm

jtaylor  (deleted user)

Done.

Done.

5:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:08 pm

jtaylor  (deleted user)

Done.

Done.

5:07 pm

jtaylor  (deleted user)

Oops. DeMorganized and done.

Oops. DeMorganized and done.

4:58 pm

jtaylor  (deleted user)

Done.

Done.

4:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:51 pm

Sean Nash

Remove space between ().

Remove space between ().

4:49 pm

Sean Nash

Add blank line between declaration and code. Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true. First conditio...

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.

4:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:36 pm

Sean Nash

Restore blank line. Should be 2 blank lines above and below test support banner.

Restore blank line. Should be 2 blank lines above and below test support banner.

4:34 pm

Sean Nash

Remove blank line.

Remove blank line.

4:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:16 pm

jtaylor  (deleted user)

Done. Error propagration.

Done. Error propagration.

4:11 pm

jtaylor  (deleted user)

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

Use power loss to reset the out of position counter for the valves. CPLD and isACPowerLost used to give the valves time to settle before checking.

4:05 pm

jtaylor  (deleted user)

Done.

Done.

4:01 pm

jtaylor  (deleted user)

Done.

Done.

3:12 pm

jtaylor  (deleted user)

Done.

Done.

3:07 pm

Sean Nash

Needs an else to zero out of range counter.

Needs an else to zero out of range counter.

3:04 pm

Sean Nash

This check is too far out. Each check function inside should check this with DG comm.

This check is too far out. Each check function inside should check this with DG comm.

2:59 pm

Sean Nash

Remove this condition.

Remove this condition.