HD-DEN-16442

HD-DEN-16442

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 20 Sep 2023
1:33 pm

Dara Navaei

1:27 pm

wbracken  (deleted user) , Sean Nash and Michael Garthwaite

1:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

Dara Navaei

Done

Done

1:19 pm

Dara Navaei

Done

Done

1:19 pm

Dara Navaei

Done

Done

1:19 pm

Dara Navaei

Done

Done

1:05 pm

Sean Nash

You won't need a switch if you use an array per previous comment.

You won't need a switch if you use an array per previous comment.

1:03 pm

Sean Nash

I think this should be a constant array of floats with NUM_OF_ACID_CONC_TYPES elements and initialize here with 1.0, 2.0, 3.0.

I think this should be a constant array of floats with NUM_OF_ACID_CONC_TYPES elements and initialize here with 1.0, 2.0, 3.0.

1:02 pm

Sean Nash

Should be 3251_9

Should be 3251_9

1:01 pm

Sean Nash

should be 2251_0

should be 2251_0

Tuesday 19 Sep 2023
4:10 pm

Darren Cox

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:10 pm

Dara Navaei

Yes. The other alarms are handled in different drivers or modes. The above alarms are here to make sure HD sends the fill command after the bottles have been replaced.

Yes. The other alarms are handled in different drivers or modes. The above alarms are here to make sure HD sends the fill command after the bottles have been replaced.

4:00 pm

Darren Cox

Just these 2 alarms? Should we check for any alarm that STOPS treatment?

Just these 2 alarms? Should we check for any alarm that STOPS treatment?

1:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:09 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:09 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:02 pm

Dara Navaei

Done

Done

11:49 am

Dara Navaei

Done

Done

11:48 am

Dara Navaei

Done

Done

11:37 am

Sean Nash

I don't think we want to use recorded volume (would want inactive reservoir if we did). I think we want to use your function here that calculates the target fill volume.

I don't think we want to use recorded volume (would want inactive reservoir if we did). I think we want to use your function here that calculates the target fill volume.

11:30 am

Sean Nash

Should we have a local var for active reservoir too?

Should we have a local var for active reservoir too?

11:29 am

Sean Nash

Should this be active reservoir?

Should this be active reservoir?

11:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 18 Sep 2023
9:00 pm

Dara Navaei

Done

Done

9:00 pm

Dara Navaei

Done

Done