HD-DEN-5381

HD-DEN-5381

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 6,916
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 30 Dec 2020
2:40 pm

qnguyen  (deleted user)

2:10 pm

pmontazemi  (deleted user) and Sean Nash

Tuesday 29 Dec 2020
10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 17 Dec 2020
4:20 pm

qnguyen  (deleted user)

It is at the beginning of Prime sub-mode.

It is at the beginning of Prime sub-mode.

4:17 pm

Sean Nash

Where did command to start reservoir 2 as active get moved to?

Where did command to start reservoir 2 as active get moved to?

1:26 pm

qnguyen  (deleted user)

Moved into its own state.

Moved into its own state.

1:14 pm

qnguyen  (deleted user)

Removed.

Removed.

1:13 pm

qnguyen  (deleted user)

Done.

Done.

1:13 pm

qnguyen  (deleted user)

Done.

Done.

1:12 pm

qnguyen  (deleted user)

Added common into code review.

Added common into code review.

10:56 am

Sean Nash

I think this waiting for DG should be done in its own state.

I think this waiting for DG should be done in its own state.

10:48 am

Sean Nash

Should be an elseif?

Should be an elseif?

10:47 am

Sean Nash

I didn't see these states defined in this module. Where is the enum declared? If in common, I don't see common code in this code review project.

I didn't see these states defined in this module. Where is the enum declared? If in common, I don't see common code in this code review project.

10:44 am

Sean Nash

Moved to common AlarmDefs.h.

Moved to common AlarmDefs.h.

10:38 am

Sean Nash

Should reset state to start state here or we won't be able to do a second treatment.

Should reset state to start state here or we won't be able to do a second treatment.

9:22 am

pmontazemi  (deleted user)

If commented code, either remove it or add TODO comment to remember to either uncomment it or delete it in the future.

If commented code, either remove it or add TODO comment to remember to either uncomment it or delete it in the future.

9:21 am

pmontazemi  (deleted user)

Where were these moved to?

Where were these moved to?

8:40 am

qnguyen  (deleted user)

HD-DEN-5381_HD Prime Blood Side
HD-DEN-5381_HD Prime Blood Side