HD-DEN-6372

HD-DEN-6372_HD Rinseback
HD-DEN-6372_HD Rinseback
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Need to fix doxygen style. @details Inputs: @details Outputs:

Need to fix doxygen style.
@details Inputs:
@details Outputs:

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RTCs are sync'd by UI sending its date/time to HD and DG f/w. However, RTC time is not used for treatment time. Treatment time is accumulated using HD timer counter. HD then uses this and set treat...

RTCs are sync'd by UI sending its date/time to HD and DG f/w.
However, RTC time is not used for treatment time. Treatment time is accumulated using HD timer counter. HD then uses this and set treatment duration to calculate time remaining. All are then sent to UI regularly.

Done.

Done.

Aligned.

Aligned.

1. How are we syncing times between UI RTC and HD RTC? 2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI...

1. How are we syncing times between UI RTC and HD RTC?
2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI APP?

Align comment.

Align comment.

Consider using TREATMENT_STATE_DATA_T data structure.

Consider using TREATMENT_STATE_DATA_T data structure.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Timeout is not in ms. Renamed constant.

Timeout is not in ms. Renamed constant.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Is that a rule in our coding standard?

Is that a rule in our coding standard?

Fixed.

Fixed.