HD-DEN-6890

HD-DEN-6890

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 6,916
Last Commit: 19 Nov 25
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 12 Mar 2021
11:15 am

Dara Navaei

11:15 am

Dara Navaei , qnguyen  (deleted user) and Sean Nash

Thursday 11 Mar 2021
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

pmontazemi  (deleted user)

Addressed.

Addressed.

9:54 am

Sean Nash

I think you should call clearAlarmCondition() when you sense DRY state.

I think you should call clearAlarmCondition() when you sense DRY state.

9:28 am

pmontazemi  (deleted user)

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

9:28 am

pmontazemi  (deleted user)

No, we do not.

No, we do not.

9:27 am

pmontazemi  (deleted user)

Addressed.

Addressed.

Wednesday 10 Mar 2021
6:13 pm

qnguyen  (deleted user)

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

6:11 pm

qnguyen  (deleted user)

Do we need different states if the purpose is to trigger an alarm?

Do we need different states if the purpose is to trigger an alarm?

5:42 pm

qnguyen  (deleted user)

Includes should be in alphabet order for organize purpose.

Includes should be in alphabet order for organize purpose.

2:06 pm

pmontazemi  (deleted user)

1:56 pm

pmontazemi  (deleted user)

Added.

Added.

1:51 pm

pmontazemi  (deleted user)

Removed.

Removed.

Tuesday 09 Mar 2021
4:56 pm

Sean Nash

Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

4:55 pm

Sean Nash

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

1:34 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:31 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:30 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:22 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:19 pm

Sean Nash

Also mention return value in @return of header.

Also mention return value in @return of header.