HD-SPRINT4

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Generated from HALCoGen

Generated from HALCoGen

Done.

Done.

I like to always place spaces between arguments and mathematical signs.

I like to always place spaces between arguments and mathematical signs.

Were these CAN registers re-generated from HALCoGen or manually changed?

Were these CAN registers re-generated from HALCoGen or manually changed?

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

As is. RESOLVED IN CODE WALKTHROUGH

As is. RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Shouldn't this be |= . If yes, rethink for the remainder of the function in this module

Shouldn't this be |= . If yes, rethink for the remainder of the function in this module

I think this should be clear enough. MSB stands for most significant BYTE, so it should be clear we are masking off 8 bits.

I think this should be clear enough. MSB stands for most significant BYTE, so it should be clear we are masking off 8 bits.

I thought this might be a little faster this way, but I guess this function will always be working on small memory ranges as it's used for messages - so I'll make this change as you recommended.

I thought this might be a little faster this way, but I guess this function will always be working on small memory ranges as it's used for messages - so I'll make this change as you recommended.

Renamed #define to clarify # of bits.

Renamed #define to clarify # of bits.

MASK_OFF_MSB (indicates how many bits), e.g., MASK_OFF_4_MSB

MASK_OFF_MSB (indicates how many bits), e.g., MASK_OFF_4_MSB

do not use address++ in calculation. It is confusing. Use it after.

do not use address++ in calculation. It is confusing. Use it after.

Because this is a calculation, add how many bits are you shifting. SHIFT_5_BITS_IN_BYTE to make it more readable.

Because this is a calculation, add how many bits are you shifting. SHIFT_5_BITS_IN_BYTE to make it more readable.

Is this a convention we want to impose? Why should output be on left?

Is this a convention we want to impose? Why should output be on left?

Is this a convention we want to impose? I have "data" in many places already.

Is this a convention we want to impose? I have "data" in many places already.