HD-SPRINT4

HD-SPRINT4

Activity on this page:
Saturday 07 Dec 2019
11:36 am

Dara Navaei

Wednesday 04 Dec 2019
8:58 am

Dara Navaei and lbaloa  (deleted user)

Tuesday 03 Dec 2019
3:53 pm

pmontazemi  (deleted user)

Friday 15 Nov 2019
10:19 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:18 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 30 Oct 2019
10:06 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:05 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 29 Oct 2019
9:21 am

Sean Nash

Generated from HALCoGen

Generated from HALCoGen

9:19 am

Sean Nash

Done.

Done.

8:37 am

pmontazemi  (deleted user)

I like to always place spaces between arguments and mathematical signs.

I like to always place spaces between arguments and mathematical signs.

Monday 28 Oct 2019
3:41 pm

pmontazemi  (deleted user)

Were these CAN registers re-generated from HALCoGen or manually changed?

Were these CAN registers re-generated from HALCoGen or manually changed?

Friday 25 Oct 2019
10:27 am

lbaloa  (deleted user)

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

10:26 am

lbaloa  (deleted user)

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

10:25 am

lbaloa  (deleted user)

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

10:24 am

lbaloa  (deleted user)

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

10:24 am

lbaloa  (deleted user)

as is RESOLVED IN CODE WALKTHROUGH

as is RESOLVED IN CODE WALKTHROUGH

10:21 am

lbaloa  (deleted user)

As is. RESOLVED IN CODE WALKTHROUGH

As is. RESOLVED IN CODE WALKTHROUGH

10:17 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:12 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:11 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:09 am

lbaloa  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:09 am

lbaloa  (deleted user)

Shouldn't this be |= . If yes, rethink for the remainder of the function in this module

Shouldn't this be |= . If yes, rethink for the remainder of the function in this module

Thursday 24 Oct 2019
12:45 pm

Sean Nash

I think this should be clear enough. MSB stands for most significant BYTE, so it should be clear we are masking off 8 bits.

I think this should be clear enough. MSB stands for most significant BYTE, so it should be clear we are masking off 8 bits.

12:43 pm

Sean Nash

I thought this might be a little faster this way, but I guess this function will always be working on small memory ranges as it's used for messages - so I'll make this change as you recommended.

I thought this might be a little faster this way, but I guess this function will always be working on small memory ranges as it's used for messages - so I'll make this change as you recommended.

12:40 pm

Sean Nash

Renamed #define to clarify # of bits.

Renamed #define to clarify # of bits.

9:09 am

lbaloa  (deleted user)

MASK_OFF_MSB (indicates how many bits), e.g., MASK_OFF_4_MSB

MASK_OFF_MSB (indicates how many bits), e.g., MASK_OFF_4_MSB

9:08 am

lbaloa  (deleted user)

do not use address++ in calculation. It is confusing. Use it after.

do not use address++ in calculation. It is confusing. Use it after.

9:08 am

lbaloa  (deleted user)

Because this is a calculation, add how many bits are you shifting. SHIFT_5_BITS_IN_BYTE to make it more readable.

Because this is a calculation, add how many bits are you shifting. SHIFT_5_BITS_IN_BYTE to make it more readable.

9:08 am

Sean Nash

Is this a convention we want to impose? Why should output be on left?

Is this a convention we want to impose? Why should output be on left?

9:01 am

Sean Nash

Is this a convention we want to impose? I have "data" in many places already.

Is this a convention we want to impose? I have "data" in many places already.