LEAHI-DD-FIRMWARE-LDT-618

Added.

Added.

We still need this if statement.

We still need this if statement.

LEAHI-DD-FIRMWARE-LDT-618_DD: Add ability to override individual treatment parameters.
LEAHI-DD-FIRMWARE-LDT-618_DD: Add ability to override individual treatment parameters.
Updated

Updated

Updated

Updated

Changed

Changed

Changed the comments

Changed the comments

Updated

Updated

Updated

Updated

Add blank line before return statement.

Add blank line before return statement.

Add blank line before return statement.

Add blank line before return statement.

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by D...

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment.

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

Removed

Removed

Removed

Removed

Updated

Updated

Noted.

Noted.

Changed this section and rewritten

Changed this section and rewritten

Updated

Updated

Yeah, I removed this.

Yeah, I removed this.

Yes, I used MSG_ID_AVAILABLE_2.

Yes, I used MSG_ID_AVAILABLE_2.

Done.

Done.

Noted.

Noted.

Noted.

Noted.

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?