LEAHI-TESTSUITES-LDT-2971

try catch is avoided as per suggestion

try catch is avoided as per suggestion

try catch is removed

try catch is removed

Moved all the constants to config.py file

Moved all the constants to config.py file

Removed the line

Removed the line

Method name is changed and added docstring and method is available in navigation.py file

Method name is changed and added docstring and method is available in navigation.py file

Method is moved to navigation.py file

Method is moved to navigation.py file

code is aligned

code is aligned

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

Please add a docstring for this function. And the naming seems like to be better like: navigation_pageIndicator_step(vStep_name)

Please add a docstring for this function.
And the naming seems like to be better like:

navigation_pageIndicator_step(vStep_name)
Same (translation)

Same (translation)

The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere.

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

should this method be moved to navigation.py?

should this method be moved to navigation.py?

remove commented out line

remove commented out line

please move these into the config.py to be consistent with other test cases

please move these into the config.py to be consistent with other test cases

When appropriate, align the code.

When appropriate, align the code.

As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.

Why do you need try-catch?

Why do you need try-catch?

Why do you need this? Is any editor used other than Squish? We need to make sure it is running in the Squish IDE and with its tools on the build server. Preferably, remove it to be consistent.

Why do you need this?
Is any editor used other than Squish?
We need to make sure it is running in the Squish IDE and with its tools on the build server.
Preferably, remove it to be consistent.

Added the line

Added the line

Added the line

Added the line

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

Modified the step to get all elements in the list dynamically and performing the action based on user input

Modified the step to get all elements in the list dynamically and performing the action based on user input

With new ui change after click on confirm no need to change the mode Is this ok Can you please confirm

With new ui change after click on confirm no need to change the mode Is this ok Can you please confirm

I am able to click on Heparin button

I am able to click on Heparin button

my test is failing here due to not clicking on the heparin tab. Are you seeing the same issue?

my test is failing here due to not clicking on the heparin tab. Are you seeing the same issue?

should this be MODE_TREA ?

should this be MODE_TREA ?

this may not work all the time the number of pre treatment steps are not a exact number of steps the steps are created dyniamically. Steps depend on: *advanced / standard mode *water sample feat...

this may not work all the time the number of pre treatment steps are not a exact number of steps the steps are created dyniamically.

Steps depend on:

  • advanced / standard mode
  • water sample featured/defreatured


Keep this in mind and let come up with a way to navigate through the steps.

Something like getting the "StepNavitgationTitleBar" componenet and accessing the "stepNames" property will give you a string list of the pre treatment steps. This is generating every time we enter pretreatment upon the conditions the test steps are made dynamically.

Updated as per new modification

Updated as per new modification