LEAHI-TESTSUITES-LDT-2971

LEAHI-TESTSUITES-LDT-2971

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 8
Total Commits: 3,340
Last Commit: 23 Mar
Commits this week: 8

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 05 Feb
4:43 pm

Nicholas Ramirez

3:25 pm

Behrouz NematiPour

3:23 pm

Behrouz NematiPour

ok them be careful to always use it as: import squish NOT the following as has been stated: from squish import *

ok them be careful to always use it as:

import squish

NOT the following as has been stated:

from squish import  *
10:25 am

Nicholas Ramirez

i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

10:20 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

10:19 am

Vendor - TEL - Divya Sree Nidamamidi

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

9:41 am

Behrouz NematiPour

Please remove squish import everywhere. It is also duplicate here.

Please remove squish import everywhere.
It is also duplicate here.

Tuesday 03 Feb
12:43 am

Vendor - TEL - Divya Sree Nidamamidi

try catch is avoided as per suggestion

try catch is avoided as per suggestion

12:42 am

Vendor - TEL - Divya Sree Nidamamidi

try catch is removed

try catch is removed

12:42 am

Vendor - TEL - Divya Sree Nidamamidi

Moved all the constants to config.py file

Moved all the constants to config.py file

12:41 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the line

Removed the line

12:40 am

Vendor - TEL - Divya Sree Nidamamidi

Method name is changed and added docstring and method is available in navigation.py file

Method name is changed and added docstring and method is available in navigation.py file

12:40 am

Vendor - TEL - Divya Sree Nidamamidi

Method is moved to navigation.py file

Method is moved to navigation.py file

Monday 02 Feb
10:45 pm

Vendor - TEL - Divya Sree Nidamamidi

code is aligned

code is aligned

10:39 pm

Vendor - TEL - Divya Sree Nidamamidi

All strings are placed in config.py

All strings are placed in config.py

10:38 pm

Vendor - TEL - Divya Sree Nidamamidi

All strings are placed in config.py

All strings are placed in config.py

Friday 30 Jan
10:17 am

Behrouz NematiPour

Please add a docstring for this function. And the naming seems like to be better like: navigation_pageIndicator_step(vStep_name)

Please add a docstring for this function.
And the naming seems like to be better like:

navigation_pageIndicator_step(vStep_name)
10:12 am

Behrouz NematiPour

Same (translation)

Same (translation)

10:11 am

Behrouz NematiPour

The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere.

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

10:11 am

Nicholas Ramirez

should this method be moved to navigation.py?

should this method be moved to navigation.py?

10:09 am

Nicholas Ramirez

remove commented out line

remove commented out line

10:07 am

Nicholas Ramirez

please move these into the config.py to be consistent with other test cases

please move these into the config.py to be consistent with other test cases

10:02 am

Behrouz NematiPour

When appropriate, align the code.

When appropriate, align the code.

9:59 am

Behrouz NematiPour

As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.

9:58 am

Behrouz NematiPour

Why do you need try-catch?

Why do you need try-catch?

9:56 am

Behrouz NematiPour

Why do you need this? Is any editor used other than Squish? We need to make sure it is running in the Squish IDE and with its tools on the build server. Preferably, remove it to be consistent.

Why do you need this?
Is any editor used other than Squish?
We need to make sure it is running in the Squish IDE and with its tools on the build server.
Preferably, remove it to be consistent.

Thursday 29 Jan
10:07 pm

Vendor - TEL - Divya Sree Nidamamidi

Added the line

Added the line

10:06 pm

Vendor - TEL - Divya Sree Nidamamidi

Added the line

Added the line

2:09 pm

Nicholas Ramirez

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

2:09 pm

Nicholas Ramirez

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)