UI-DEN-4690

UI-DEN-4690

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 15 Oct 2020
10:16 am

Behrouz NematiPour

Wednesday 14 Oct 2020
11:09 pm

pmontazemi  (deleted user) and plucia  (deleted user)

10:40 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:40 am

plucia  (deleted user)

Fair, not related to story. RESOLVED.

Fair, not related to story.

RESOLVED.

10:39 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:38 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:35 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:34 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:34 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:33 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:32 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:31 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:29 am

plucia  (deleted user)

RESOLVED

RESOLVED

Tuesday 13 Oct 2020
6:01 pm

Behrouz NematiPour

Please refer to the newer code review after the max revision has been changed which has all the latest commits. http://192.168.10.132:8060/cru/UI-DEN-4690-2-1 Seems like it has appeared here as well.

Please refer to the newer code review after the max revision has been changed which has all the latest commits.
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1
Seems like it has appeared here as well.

6:00 pm

Behrouz NematiPour

"*** Off the subject ***" This is not related to the story and is a code coverage of another story. Regardless it was decided to manually test the CANBus at that moment since it could be better tes...

"*** Off the subject ***"
This is not related to the story and is a code coverage of another story.
Regardless it was decided to manually test the CANBus at that moment since it could be better tested with more accurate results which all of those test couldn't be achieved manually and took a long time to test because 10 or 100 of thousands of frames tested and wasn't reasonable to do it each time automatically on server with virtual CANBus and had to be tested on a real physical CANBus.
I hope this is enough information!

5:59 pm

Behrouz NematiPour

DISABLE_CRC is only for development debugging purposes. and is not part of this function definition. Will be defined/enabled in case for debugging.

DISABLE_CRC is only for development debugging purposes.
and is not part of this function definition.
Will be defined/enabled in case for debugging.

5:58 pm

Behrouz NematiPour

I think if it's not false (false if the vData of type QByteArray is not sufficient regarding vAction) then it would be true, right ?!

I think if it's not false (false if the vData of type QByteArray is not sufficient regarding vAction) then it would be true, right ?!

5:57 pm

Behrouz NematiPour

"*** Off the subject **" There are tests (manually/automatically) for that and the application quits properly. If terminates by SquishCoco or being killed in the terminal may not have time to clea...

"*** Off the subject **"

There are tests (manually/automatically) for that and the application quits properly.
If terminates by SquishCoco or being killed in the terminal may not have time to clean up correctly.
When shuts down by user within the UI by user quits nicely and clean.

"** Also please don't check "Needs resolution" for every comment you make, it happened many times regardless of mentioning it multiple times ***"

5:56 pm

Behrouz NematiPour

"*** Off the subject ***" At the time of testing application with SquishCoco, observed that Coco can't safely quit application and terminates the application and don't call the correct quit method ...

"*** Off the subject ***"
At the time of testing application with SquishCoco, observed that Coco can't safely quit application and terminates the application and don't call the correct quit method of the application and that makes sense since the Squish Coco is another application and will immediately terminate the UI application and don't know how to properly quit the UI application.
So UI application can't safely quit the threads.
Therefore some threading features has been manually tested.
The quitThread in each class is basically should name moveThread (move to main thread).

I hope this is enough information !

Wednesday 07 Oct 2020
10:49 pm

Behrouz NematiPour

Added http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18398 line 203

Added
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18398
line 203

10:48 pm

Behrouz NematiPour

How is framFlags related to this function? The return type is FrameCount and as it says it is the count of frames that had an error as the function comment says.

How is framFlags related to this function?
The return type is FrameCount and as it says it is the count of frames that had an error as the function comment says.

10:47 pm

Behrouz NematiPour

Added http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18400 line 152

Added
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18400
line 152

10:46 pm

Behrouz NematiPour

added. please refer to http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18381 line 44

added.
please refer to http://192.168.10.132:8060/cru/UI-DEN-4690-2-1#CFR-18381
line 44

10:43 pm

Behrouz NematiPour

Added

Added

10:12 pm

Behrouz NematiPour

It is all documentations and Doxygenization. If you see otherwise is because the file names changed and the code review takes it as a new file and marks all the file content as to be reviewed. Let ...

It is all documentations and Doxygenization.
If you see otherwise is because the file names changed and the code review takes it as a new file and marks all the file content as to be reviewed.
Let me know if otherwise.

10:02 pm

Behrouz NematiPour

what docstring, where in the code?

what docstring, where in the code?

10:01 pm

Behrouz NematiPour

What do you mean by : "if init() changes, this function will behave differently, but it won't be reflected in the documentation" the function document says the same thing: "returns the return value...

What do you mean by :
"if init() changes, this function will behave differently, but it won't be reflected in the documentation"
the function document says the same thing:
"returns the return value of the init() method"
so if init() changes this function return changes because it's an overloaded method of the init() function.

2:44 pm

plucia  (deleted user)

Missing details and description

Missing details and description

2:42 pm

plucia  (deleted user)

Should indicate the return type and what is returned when. if init() changes, this function will behave differently, but it won't be reflected in the documentation

Should indicate the return type and what is returned when. if init() changes, this function will behave differently, but it won't be reflected in the documentation

2:40 pm

plucia  (deleted user)

The docstrings need to include information about when true and false are returned

The docstrings need to include information about when true and false are returned