UI-DEN-4860-BLE

UI-DEN-4860-BLE

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,303
Last Commit: 20 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 27 Jan 2021
11:03 am

plucia  (deleted user)

10:11 am

pmontazemi  (deleted user)

Tuesday 26 Jan 2021
1:44 am

Behrouz NematiPour

1:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

Wednesday 20 Jan 2021
11:57 am

plucia  (deleted user)

Done

Done

Monday 18 Jan 2021
5:32 pm

Behrouz NematiPour

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has. 2 - in your timerEvent { ... if( ! _tim...

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has.
2 - in your 

timerEvent {
    ...
    if( ! _timerIsActive ) return;
    ...
}
5:16 pm

plucia  (deleted user)

Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped. That's the inte...


Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.


That's the intention - to stop the timer. Since the UI is continually trying to reconnect to the last paired device while it is off, if a user goes into the bluetooth settings page and hits "Scan for devices", the timer is stopped during the scan to avoid conflicts between the timer and the scan.


I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.


This doesn't make sense to me, can you clarify?

4:52 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:50 pm

Behrouz NematiPour

I am not sure killing the QObject timer would be a good idea, but also I couldn't find any recommendation not to do it. Since any object has only one timer I have a feeling that by killing the obje...

I am not sure killing the QObject timer would be a good idea, but also I couldn't find any recommendation not to do it.
Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.

I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.

4:44 pm

Behrouz NematiPour

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so. Not 100% agree. Also, we need to have a consistent naming for ...

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so.
Not 100% agree.
Also, we need to have a consistent naming for the currently existing objectName in the code, I'll later provide a standard.

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:39 pm

Behrouz NematiPour

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen. RESOLVED

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen.
RESOLVED

4:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary. RESOLVED regardless.

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary.
RESOLVED regardless.

4:33 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:33 pm

Behrouz NematiPour

RESOLVED

RESOLVED

Friday 15 Jan 2021
11:47 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:34 am

plucia  (deleted user)

Done

Done

9:17 am

plucia  (deleted user)

Done

Done

Thursday 14 Jan 2021
8:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:44 pm

Behrouz NematiPour

So we may need to be careful when we are adding the WiFi driver in here later. RESOLVED.

So we may need to be careful when we are adding the WiFi driver in here later.
RESOLVED.

4:43 pm

Behrouz NematiPour

Perfect, RESOLVED.

Perfect,
RESOLVED.

4:42 pm

Behrouz NematiPour

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files. Since the SD card might be damaged and we sti...

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.

4:39 pm

Behrouz NematiPour

Oh I see. RESOLVED

Oh I see.
RESOLVED

Wednesday 13 Jan 2021
4:51 pm

plucia  (deleted user)

It's in the UX design here: https://app.zeplin.io/project/5e160353a7c41a9404596a70/screen/5e5060d3f75589612aee8b68

It's in the UX design here: https://app.zeplin.io/project/5e160353a7c41a9404596a70/screen/5e5060d3f75589612aee8b68

4:50 pm

plucia  (deleted user)

See response above

See response above

4:50 pm

plucia  (deleted user)

See response above

See response above