Behrouz NematiPour

About
  • First commit 24 September 2019
  • Latest commit 03 November 2025
Last Week All Time
Commits: 0 2,874

Reviews

45 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Behrouz NematiPour is mapped to 58 committers over 25 repositories
Username bnematipour is mapped to:
Today
4 hrs ago

Behrouz NematiPour

Since this is being used everywhere, I would recommend defining a global variable(s) so that we can later be flexible to adjust that for all the mouse clicks or watforobject functions

Since this is being used everywhere, I would recommend defining a global variable(s) so that we can later be flexible to adjust that for all the mouse clicks or watforobject functions

4 hrs ago

Behrouz NematiPour

Shouldn't this function be defined in a more general location/file? And same comment here to be aware of the translation flexibility for later.

Shouldn't this function be defined in a more general location/file?
And same comment here to be aware of the translation flexibility for later.

4 hrs ago

Behrouz NematiPour

Not able to find in your test.py, but these types of texts will change with the translation, and if the text is used as has been defined here, your test will fail in other languages. Just be aware ...

Not able to find in your test.py, but these types of texts will change with the translation, and if the text is used as has been defined here, your test will fail in other languages.
Just be aware and think of a solution to be flexible for later when testing with other languages.

4 hrs ago

Behrouz NematiPour

It is a little bit concerning: Could you please test/describe the following scenarios: *What if we have more than one Heparin type supported? *What if none (incorrectly) has been defined in the c...

It is a little bit concerning:
Could you please test/describe the following scenarios:

  • What if we have more than one Heparin type supported?
  • What if none (incorrectly) has been defined in the configuration (do we get an index out of bounds)?
4 hrs ago

Behrouz NematiPour

We will address this later on code modularizations. RESOLVED.

We will address this later on code modularizations.
RESOLVED.

Thursday 11 Dec
10:20 am

Behrouz NematiPour

10:19 am

Behrouz NematiPour

9:51 am

Behrouz NematiPour

9:50 am

Behrouz NematiPour

4:27 am

Behrouz NematiPour

Wednesday 10 Dec
10:19 pm

Behrouz NematiPour

9:36 pm

Behrouz NematiPour

4:54 pm

Behrouz NematiPour

I believe any related view could have provided a timer since they are inherited from QObject. That is fine for now but consider using our C++ view codes for such a thing.

I believe any related view could have provided a timer since they are inherited from QObject.
That is fine for now but consider using our C++ view codes for such a thing.

4:50 pm

Behrouz NematiPour

Thank you .

Thank you .

4:46 pm

Behrouz NematiPour

4:43 pm

Behrouz NematiPour

3:59 pm

Behrouz NematiPour

Please align.

Please align.

3:56 pm

Behrouz NematiPour

Please use the mainTreatment screen as the default. If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

Please use the mainTreatment screen as the default.
If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

3:53 pm

Behrouz NematiPour

You no longer need this after you move the heparin screen from the sections folder.

You no longer need this after you move the heparin screen from the sections folder.

3:51 pm

Behrouz NematiPour

Shouldn't ""Unfractionated 1000"" come from the configurations?

Shouldn't ""Unfractionated 1000"" come from the configurations?

3:49 pm

Behrouz NematiPour

We should add the qsTr()

We should add the qsTr()

3:48 pm

Behrouz NematiPour

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

3:37 pm

Behrouz NematiPour

We should use "min" for minutes and not "mins". Same for "hrs" => "hr".

We should use "min" for minutes and not "mins".
Same for "hrs" => "hr".

3:28 pm

Behrouz NematiPour

What is this file used for? And please add a brief description for the file comment.

What is this file used for?
And please add a brief description for the file comment.

3:26 pm

Behrouz NematiPour

Please put comments for your division number.

Please put comments for your division number.

3:26 pm

Behrouz NematiPour

statusColor is so general, but is bound to the heparinStatusColor. Please either change the status color to be heparin only or change the heparinStatus Color name to be more general. The latter is ...

statusColor is so general, but is bound to the heparinStatusColor.
Please either change the status color to be heparin only or change the heparinStatus Color name to be more general.
The latter is better.

1:44 pm

Behrouz NematiPour

No Action For Now: Same for the vError param: https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

1:43 pm

Behrouz NematiPour

No Action For Now: Please always use mError, since it is local to the script function, to be consistent with the rest. Also, usually it is a number, not a bool. It is fine for now, but later we sh...

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

10:54 am

Behrouz NematiPour

This does not entirely follow the standard. But it is fine since we do not have the Bluetooth feature implemented yet. Standard format example

This does not entirely follow the standard.
But it is fine since we do not have the Bluetooth feature implemented yet.
Standard format example

10:47 am

Behrouz NematiPour

Please use the following commands from NetworkManager utilities, since in Leahi we are not using the wpa_supplicant directly: nmcli connection delete DilaityIoT nmcli connection delete $(nmcli -t...

Please use the following commands from NetworkManager utilities, since in Leahi we are not using the wpa_supplicant directly: 

nmcli connection delete DilaityIoT 
nmcli connection delete $(nmcli -t -f NAME connection show --active)