Raghu Kallala

Add a TODO comment to change the message once implemented in FW

Add a TODO comment to change the message once implemented in FW

ROPump is repeated

ROPump is repeated

RECOVERY_STATES

RECOVERY_STATES

update params

update params

Intentional?

Intentional?

update the header and field comments in later commits

update the header and field comments in later commits

pressure limit will be unsigned int not signed int with LDT-473..beta CR Add a TODO to update once the 473 is ready to merge

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

Are these print statements add for debugging? If not, is this allowed

Are these print statements add for debugging?
If not, is this allowed

typo, PUMP_ON_STATE

typo, PUMP_ON_STATE

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

Updated

Updated

Updated

Updated

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!