Vinayakam Mani

LDT-3352 resolving merge conflicts

    • -0
    • +29
    /firmware/App/Modes/ModeGenDialysate.c
LDT-3352 heater control update

    • -0
    • +29
    /firmware/App/Modes/ModeGenDialysate.c
    • -0
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
LDT-3352 resolving merge conflicts

    • -27
    • +136
    /firmware/App/Controllers/RinsePump.c
    • -11
    • +117
    /firmware/App/Modes/ModeGenDialysate.c
    • -5
    • +15
    /firmware/App/Monitors/Temperature.c
LDT-3352 latest from staging

LDT-3352 udpated per latest staging common

LDT-3352 resolving merge conflicts

    • -60
    • +136
    /firmware/App/Controllers/Heaters.c
    • -8
    • +113
    /firmware/App/Modes/ModeGenDialysate.c
    • -5
    • +55
    /firmware/App/Monitors/Temperature.c
LDT-3352 heater control update

LDT-3352 heater control update

LDT-3352 dialysate temp control update

LDT-3352 heater control update

    • -25
    • +15
    /firmware/App/Controllers/Heaters.c
LDT-3352 heater control update

4 bytes reg.

4 bytes reg.

4 byte reg.

4 byte reg.

Remove typecast.

Remove typecast.

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

Done.

Done.

Done.

Done.

LDT-3352 heater control update

Heater control update

    • -59
    • +142
    /firmware/App/Controllers/Heaters.c
    • -10
    • +14
    /firmware/App/Modes/ModeGenDialysate.c
    • -5
    • +55
    /firmware/App/Monitors/Temperature.c
Add comments

Add comments

Align indent

Align indent

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

are we using this variable, if not, can we remove across the file?

are we using this variable, if not, can we remove across the file?