Vinayakam Mani

LDT-2004 updated changes

    • -13
    • +8
    /firmware/App/Controllers/DryBiCart.c
Merge branch 'LDT-2004-drybicarb---dd' of bitbucket.org:diality-cloud/dd-firmware into LDT-2004-drybicarb---dd

LDT-2004 resolving merge issues

    • -3
    • +3
    /firmware/App/Modes/ModeGenDialysate.c
LDT-2004 resolving merge issues

LDT-2004 drybicarb changes

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

Done.

Done.

LDT-2004 addressing code review comments

Done.

Done.

Done.

Done.

Done.

Done.

I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber...

I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber (execBicarbChamberFillMode) mode controls D80 in its sub states. So, not two execs controlling same valve. Once we identified where all modes using these execs, will come up with signals to avoid such scenarios.

Done.

Done.

Done

Done

Done

Done

Done.

Done.

LDT-2004 addressing code review comments

    • -18
    • +20
    /firmware/App/Controllers/DryBiCart.c
Merge branch 'LDT-2004-drybicarb---dd' of bitbucket.org:diality-cloud/dd-firmware into LDT-2004-drybicarb---dd

LDT-2004 drybicarb update

LDT-2004 dialin update

LDT-2004 valves update

LDT-2004 Drybicarb update

    • -4
    • +5
    /firmware/App/Modes/ModeGenDialysate.c
LDT-2004 drybicarb update

LDT-2004 spent chamber fill update

LDT-2004 bicarb chamber fill implementation

    • -4
    • +178
    /firmware/App/Controllers/DryBiCart.c
    • -0
    • +10
    /firmware/App/Modes/ModeGenDialysate.c