application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 Jan 2021
5:56 pm

Behrouz NematiPour

DEN-5838: Code Review 0

Options
    • -1
    • +2
    /cr_objectives.sh
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
5:44 pm

Behrouz NematiPour

DEN-5754: Implementation

- code refactoring and clean up

Options
    • -1
    • +1
    /denali.pro.user
    • -5
    • +8
    /denali.qrc
    • -0
    • +55
    /sources/gui/qml/components/TitleBarCreateTreatment.qml
    • -55
    • +0
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -0
    • +55
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentBase.qml
    • -0
    • +88
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentConfirm.qml
    • -0
    • +660
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +124
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentPrime.qml
    • -0
    • +123
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentUltrafiltration.qml
    • -144
    • +0
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -108
    • +0
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -670
    • +0
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -140
    • +0
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -11
    • +12
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
5:44 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:44 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:39 pm

plucia  (deleted user)

Was this added by mistake?

Was this added by mistake?

5:36 pm

plucia  (deleted user)

Can delete

Can delete

5:33 pm

plucia  (deleted user)

Can delete

Can delete

5:33 pm

plucia  (deleted user)

Why were the extra sleeps needed? I don't have them and it's working fine

Why were the extra sleeps needed? I don't have them and it's working fine

4:37 pm

Behrouz NematiPour

I only wanted to exclude them from coco, but for some, I had to completely comment them, but still kept the ones that don't require to be commented.

I only wanted to exclude them from coco, but for some, I had to completely comment them, but still kept the ones that don't require to be commented.

4:34 pm

Behrouz NematiPour

Kept it as a place holder to keep all 16 bits visibly used.

Kept it as a place holder to keep all 16 bits visibly used.

4:33 pm

Behrouz NematiPour

there were useless tests where the QVerify and QCompare were removed from them after using the template function notify.

there were useless tests where the QVerify and QCompare were removed from them after using the template function notify.

4:24 pm

Behrouz NematiPour

It still applied to the newly created file. I would prefer to have something more general like: *TextEntry And please don't use a name like "Denali" which is subject to change.

It still applied to the newly created file.
I would prefer to have something more general like:

  • TextEntry
    And please don't use a name like "Denali" which is subject to change.
4:22 pm

plucia  (deleted user)

Can delete

Can delete

4:21 pm

Behrouz NematiPour

It still applied to the newly created file.

It still applied to the newly created file.

4:21 pm

plucia  (deleted user)

Application is spelled wrong What is this for?

Application is spelled wrong
What is this for?

4:21 pm

Behrouz NematiPour

please put the even verb at the end. pressedEnter => enterPressed eg. clickedBack => backClicked clickedContinue => continueClicked **"please follow this everywhere in the code."**

please put the even verb at the end.
pressedEnter => enterPressed
eg.
clickedBack => backClicked
clickedContinue => continueClicked

**"please follow this everywhere in the code."**

4:20 pm

plucia  (deleted user)

Will there be gaps in code coverage with these removed?

Will there be gaps in code coverage with these removed?

4:17 pm

plucia  (deleted user)

Can be deleted

Can be deleted

4:15 pm

plucia  (deleted user)

AlarmClearedConditionData is commented out above but this one remains?

AlarmClearedConditionData is commented out above but this one remains?

4:13 pm

plucia  (deleted user)

Can be deleted

Can be deleted

4:13 pm

Behrouz NematiPour

Same here.

Same here.

4:13 pm

Behrouz NematiPour

Actually, No this is in the correct place and those two other components shall cover the minimize mouseArea. IF it goes last then it covers those two and they will never work.

Actually, No this is in the correct place and those two other components shall cover the minimize mouseArea.
IF it goes last then it covers those two and they will never work.

4:08 pm

plucia  (deleted user)

Shouldn't this be declared last?

Shouldn't this be declared last?

4:07 pm

plucia  (deleted user)

Shouldn't this be declared last?

Shouldn't this be declared last?

3:52 pm

Behrouz NematiPour

I have different types of comments one of them is "// DEBUG:" which we don't have a todo item for that. It only exists for later or in casede bugging that I don't want to log with that format all t...

I have different types of comments one of them is "// DEBUG:" which we don't have a todo item for that.
It only exists for later or in casede bugging that I don't want to log with that format all the time but sometimes useful for debugging.

3:49 pm

Behrouz NematiPour

By using the template function notify in lines 349,350,351 they are not required anymore. This shows how good/correct implementation helps to have a clean code.

By using the template function notify in lines 349,350,351 they are not required anymore.
This shows how good/correct implementation helps to have a clean code.

3:25 pm

pmontazemi  (deleted user)

Where was this moved to? Or was it deleted?

Where was this moved to? Or was it deleted?

3:24 pm

pmontazemi  (deleted user)

Add TODO on commented out line or delete commented line. This way, we can always find it.

Add TODO on commented out line or delete commented line. This way, we can always find it.

3:21 pm

pmontazemi  (deleted user)

Move comment outside of if statement.

Move comment outside of if statement.

3:20 pm

pmontazemi  (deleted user)

Space between functions.

Space between functions.