application

Clone Tools

Stats

Commits this week: 3
Total Committers: 14
Last Commit: 10 Feb
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Jan 2021
4:47 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -4
    • +4
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /scripts/run.sh
    • -4
    • +0
    /sources/gui/qml/components/ScreenItem.qml
    • -21
    • +8
    /sources/gui/qml/components/SettingsItem.qml
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
11:47 am

Behrouz NematiPour

same

same

11:47 am

Behrouz NematiPour

Please move it after # CANBus section.

Please move it after # CANBus section.

11:43 am

Behrouz NematiPour

please don't use the clip, it is not recommended. Also, there should not be an issue with the silent button, it has been tested! What are you trying to achieve?

please don't use the clip, it is not recommended.
Also, there should not be an issue with the silent button, it has been tested!
What are you trying to achieve?

11:43 am

Behrouz NematiPour

Why this specific dialog has been created and not NotificationDialog used and what is special about that? Please provide a screenshot to compare.

Why this specific dialog has been created and not NotificationDialog used and what is special about that?
Please provide a screenshot to compare.

11:34 am

Behrouz NematiPour

Why this color has been chosen, I don't see it in the UX design? Also, we already have the same icon with a white background.

Why this color has been chosen, I don't see it in the UX design?
Also, we already have the same icon with a white background.

11:30 am

Behrouz NematiPour

why this folder has to exist and why this naming has been chosen?

why this folder has to exist and why this naming has been chosen?

11:29 am

Behrouz NematiPour

Please put a comment about why sleep 5 has been used and what needs to be done to remove this sleep.

Please put a comment about why sleep 5 has been used and what needs to be done to remove this sleep.

11:28 am

Behrouz NematiPour

By connmand did you mean command? Is this correct? and if it is what is that? Does it mean connection manager daemon?

By connmand did you mean command?
Is this correct?
and if it is what is that?
Does it mean connection manager daemon?

11:21 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:20 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:20 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:20 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:19 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:19 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:02 am

plucia  (deleted user)

Done

Done

11:02 am

plucia  (deleted user)

Done

Done

11:02 am

plucia  (deleted user)

Done

Done

11:02 am

plucia  (deleted user)

Done

Done

11:02 am

plucia  (deleted user)

Zero works too. I've updated it to zero

Zero works too. I've updated it to zero

11:02 am

plucia  (deleted user)

Done

Done

11:01 am

plucia  (deleted user)

Done

Done

11:01 am

plucia  (deleted user)

Done

Done

11:01 am

plucia  (deleted user)

The json document holds the information about the BP cuffs we've paired with. It is also helpful to format the paired device information into json so it can be stored to disk and then re-loaded eas...

The json document holds the information about the BP cuffs we've paired with.
It is also helpful to format the paired device information into json so it can be stored to disk and then re-loaded easily so that we can automatically re-connect to the last selected BP cuff after a reboot.
The dereferencing and casting is needed to work with the ObjectList-based model approach.
All of the slots are there to receive data from the BLEScanner, so we can display available devices to connect to.
We emit signals when we want to connect/reconnect to a device, scan for devices, or request to save the paired devices to disk.

11:00 am

plucia  (deleted user)

The approach comes from Qt's documentation: It's the QObjectList-based model approach https://doc.qt.io/qt-5/qtquick-modelviewsdata-cppmodels.html, which you can see creates a list of QObject* poin...

The approach comes from Qt's documentation: It's the QObjectList-based model approach https://doc.qt.io/qt-5/qtquick-modelviewsdata-cppmodels.html, which you can see creates a list of QObject* pointers with values that are accessible as named properties in the qml.
This class has been tested and is working fine
cppcheck doesn't report any errors in this file

11:00 am

plucia  (deleted user)

Done

Done

11:00 am

plucia  (deleted user)

Done

Done

11:00 am

plucia  (deleted user)

Done

Done

11:00 am

plucia  (deleted user)

Done

Done

10:59 am

plucia  (deleted user)

Done

Done