application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Jan 2021
2:06 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +7
    /sources/view/VBluetooth.cpp
    • -2
    • +3
    /sources/view/VBluetooth.h
    • -5
    • +20
    /sources/view/VVitals.cpp
    • -3
    • +7
    /sources/view/VVitals.h
11:39 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:28 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:22 am

plucia  (deleted user)

RESOLVED

RESOLVED

Friday 15 Jan 2021
2:37 pm

pmontazemi  (deleted user)

2:36 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:36 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:53 am

plucia  (deleted user)

Noted

Noted

11:47 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:41 am

Behrouz NematiPour

The code review has to be automatic. It has to be added to the code review by Crucible not the developer as of our process. Please create code reviews that are automatic and not modified by the dev...

The code review has to be automatic.
It has to be added to the code review by Crucible not the developer as of our process.
Please create code reviews that are automatic and not modified by the developer otherwise it would be out of context and useless.

11:39 am

Behrouz NematiPour

I checked out to the branch and I don't see the usage of this class in any QML file.

I checked out to the branch and I don't see the usage of this class in any QML file.

11:37 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:37 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:25 am

plucia  (deleted user)

I've added it now, looks like it was accidently omitted

I've added it now, looks like it was accidently omitted

11:25 am

plucia  (deleted user)

Done

Done

10:58 am

plucia  (deleted user)

Like the other view classes that have 'V' as a prefix, the VBluetoothDeviceInfo has properties that are accessed directly by the QML It could be called BluetoothDeviceInfo instead? Or, what would y...

Like the other view classes that have 'V' as a prefix, the VBluetoothDeviceInfo has properties that are accessed directly by the QML
It could be called BluetoothDeviceInfo instead? Or, what would you prefer?

10:41 am

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
10:34 am

plucia  (deleted user)

Done

Done

10:33 am

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -0
    • +1
    /.gitignore
    • -0
    • +10
    /denali.pro
    • -5
    • +5
    /denali.pro.user
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +5
    /sources/storage/StorageGlobals.cpp
    • -10
    • +10
    /sources/view/VBluetooth.cpp
    • -1
    • +1
    /sources/view/VBluetooth.h
9:17 am

plucia  (deleted user)

Done

Done

Thursday 14 Jan 2021
8:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:44 pm

Behrouz NematiPour

So we may need to be careful when we are adding the WiFi driver in here later. RESOLVED.

So we may need to be careful when we are adding the WiFi driver in here later.
RESOLVED.

4:43 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Preventing create treatment class from thinking a new treatment profile was saved when the bledevices.conf file is updated.

Options
    • -4
    • +14
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +2
    /sources/view/VTreatmentCreate.h
4:43 pm

Behrouz NematiPour

Perfect, RESOLVED.

Perfect,
RESOLVED.

4:42 pm

Behrouz NematiPour

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files. Since the SD card might be damaged and we sti...

We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.

4:39 pm

Peter Lucia <plucia@diality.com>

DEN-4867: Addressed code review comments

Options
    • -20
    • +60
    /sources/bluetooth/BLEScanner.cpp
    • -2
    • +9
    /sources/bluetooth/BLEScanner.h
4:39 pm

Behrouz NematiPour

Oh I see. RESOLVED

Oh I see.
RESOLVED

3:32 pm

Behrouz NematiPour

deleted.

deleted.

3:31 pm

Behrouz NematiPour

Good catch, Dleted.

Good catch,
Dleted.