application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 27 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Jan 2021
6:32 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +4
    /sources/view/VBluetooth.cpp
5:32 pm

Behrouz NematiPour

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has. 2 - in your timerEvent { ... if( ! _tim...

1 - I mean that timer is not only for handling our implementation it may have another purpose which we are stopping by killing the only timer it has.
2 - in your 

timerEvent {
    ...
    if( ! _timerIsActive ) return;
    ...
}
5:19 pm

Behrouz NematiPour

This is a leak/bug. Leak: A pointer to an object has been removed from the list and the object still exists and utilizing the memory (bug: and may even still doing some tasks).

This is a leak/bug.
Leak: A pointer to an object has been removed from the list and the object still exists and utilizing the memory (bug: and may even still doing some tasks).

5:16 pm

plucia  (deleted user)

Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped. That's the inte...


Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.


That's the intention - to stop the timer. Since the UI is continually trying to reconnect to the last paired device while it is off, if a user goes into the bluetooth settings page and hits "Scan for devices", the timer is stopped during the scan to avoid conflicts between the timer and the scan.


I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.


This doesn't make sense to me, can you clarify?

5:12 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:52 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:50 pm

Behrouz NematiPour

I am not sure killing the QObject timer would be a good idea, but also I couldn't find any recommendation not to do it. Since any object has only one timer I have a feeling that by killing the obje...

I am not sure killing the QObject timer would be a good idea, but also I couldn't find any recommendation not to do it.
Since any object has only one timer I have a feeling that by killing the object's only timer, then any refreshing or chores for any kind of signal/slot maintenance will be stoped.

I prefer to have a boolean flag to return from the virtual method in case we don't need it to handle the functionality we put there.

4:44 pm

Behrouz NematiPour

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so. Not 100% agree. Also, we need to have a consistent naming for ...

When we add the correct object dictionary in the names.py then sys/v&v/... can use it and don't need the object name anymore to do so.
Not 100% agree.
Also, we need to have a consistent naming for the currently existing objectName in the code, I'll later provide a standard.

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:39 pm

Behrouz NematiPour

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen. RESOLVED

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen.
RESOLVED

4:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary. RESOLVED regardless.

It's not the components themselves that do what you want it's how you call and manage it and having another component was unnecessary.
RESOLVED regardless.

4:33 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:33 pm

Behrouz NematiPour

RESOLVED

RESOLVED

2:08 pm

plucia  (deleted user)

For VBluetoothDeviceInfo's usage in QML, see SettingsBluetooth.qml lines 204, lines 212 text: modelData.name and text: modelData.address These properties are defined in VBluetoothDeviceInfo.h

For VBluetoothDeviceInfo's usage in QML, see SettingsBluetooth.qml lines 204, lines 212 

 text: modelData.name

and

 text: modelData.address


These properties are defined in VBluetoothDeviceInfo.h

2:08 pm

plucia  (deleted user)

Done

Done

2:07 pm

plucia  (deleted user)

Done

Done

2:07 pm

plucia  (deleted user)

Done

Done

2:07 pm

plucia  (deleted user)

Done

Done

2:06 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments

Options
    • -1
    • +7
    /sources/view/VBluetooth.cpp
    • -2
    • +3
    /sources/view/VBluetooth.h
    • -5
    • +20
    /sources/view/VVitals.cpp
    • -3
    • +7
    /sources/view/VVitals.h
11:39 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:28 am

Behrouz NematiPour

RESOLVED

RESOLVED

11:22 am

plucia  (deleted user)

RESOLVED

RESOLVED

Friday 15 Jan 2021
2:37 pm

pmontazemi  (deleted user)

2:36 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

2:36 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:53 am

plucia  (deleted user)

Noted

Noted