application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 Jan 2021
10:54 am

Behrouz NematiPour

Merge branch 'master' into DEN-5736_UI_Heparin_Bolus

Options
10:49 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:48 am

Behrouz NematiPour

needs to investigate more or done later. RESOLVED

needs to investigate more or done later.
RESOLVED

10:47 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:47 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:47 am

plucia  (deleted user)

Resolved as per our code review 1.27.2021

Resolved as per our code review 1.27.2021

10:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:41 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:41 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:41 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:41 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:40 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:38 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:37 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:37 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:36 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:35 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:26 am

Behrouz NematiPour

it may contain other settings so please don't ignore it in .gitignore.

it may contain other settings so please don't ignore it in .gitignore.

10:11 am

pmontazemi  (deleted user)

10:01 am

plucia  (deleted user)

You asked for this change: We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files. Since the SD car...

You asked for this change:


We need to have a folder next to the application for all the settings since it is not related to the treatment it is only settings configuration files.
Since the SD card might be damaged and we still need to store settings.
Please change it to refer to the application location and name the folder as configuration or settings.


Here's a screenshot: X:\Users\PeterL\ForBehrouz\settings.png

Tuesday 26 Jan 2021
1:44 am

Behrouz NematiPour

1:42 am

Behrouz NematiPour

RESOLVED

RESOLVED

Monday 25 Jan 2021
3:58 pm

Behrouz NematiPour

UI-DEN-5751_Pre Treatment Ultrafiltration
UI-DEN-5751_Pre Treatment Ultrafiltration
Sunday 24 Jan 2021
9:13 pm

Behrouz NematiPour

DEN-6612 UI_DVT: Pre-Treatment Ultrafiltration

- This story wasn't part of the current sprint S37 but while I worked on it to be able to push it to master ASAP, so put the story as the commit comment.

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +2
    /sources/view/VTreatmentBegin.h
    • -2
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +14
    /unittests/tst_messaging.cpp
    • -0
    • +1
    /unittests/tst_messaging.h
    • -0
    • +46
    /unittests/tst_models.cpp
    • -0
    • +3
    /unittests/tst_models.h
1:59 pm

Behrouz NematiPour

Why the doGetDevices is a public slots, therefore, is publicly accessible while you have a property defined for that? That's one of the reasons why I insisted to use macros to avoid this kind of in...

Why the doGetDevices is a public slots, therefore, is publicly accessible while you have a property defined for that?
That's one of the reasons why I insisted to use macros to avoid this kind of inconsistencies.
Also, the name of the property/signal/slot does not match.
if the property type is vTYPE and its name is vVARIABLE and the vSIGNAL is "Changed" then by PROPERTY macro definition it has to be like below with slot defined as private.

Q_PROPERTY(     vTYPE   vVARIABLE                                   \
                 READ   vVARIABLE                                   \
                 WRITE  vVARIABLE                                   \
                 NOTIFY vVARIABLE##vSIGNAL)                         \


The do/did/on prefixes will be used for none property matters.

12:44 pm

Behrouz NematiPour

what is this? why created and why ignored?

what is this?
why created and why ignored?

12:29 pm

Behrouz NematiPour

This is not a prefered approach and there are better ways of doing it. As Qt mentions in the document: QAbstractItemModel Subclass A model can be defined by subclassing QAbstractItemModel. This i...

This is not a prefered approach and there are better ways of doing it.
As Qt mentions in the document:


QAbstractItemModel Subclass
A model can be defined by subclassing QAbstractItemModel. This is the best approach if you have a more complex model that cannot be supported by the other approaches. A QAbstractItemModel can also automatically notify a QML view when the model data changes.

12:22 pm

Behrouz NematiPour

it has been done before please don't do this again RESOLVED

it has been done before please don't do this again
RESOLVED